Bug 229074

Summary: [css-flexbox] Add support for start & end css-align-3 positional alignment properties
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: Layout and RenderingAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, rbuis, ryanhaddad, sam, simon.fraser, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch simon.fraser: review+

Sergio Villar Senin
Reported 2021-08-13 08:08:01 PDT
[css-flexbox] Add initial support for css-align-3 positional alignment properties
Attachments
Patch (31.28 KB, patch)
2021-08-13 08:47 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Patch (32.17 KB, patch)
2021-08-13 10:18 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Patch (32.20 KB, patch)
2021-08-16 02:11 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Patch (32.26 KB, patch)
2021-08-31 03:00 PDT, Sergio Villar Senin 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2021-08-13 08:47:40 PDT
Created attachment 435484 [details] Patch
Sergio Villar Senin
Comment 2 2021-08-13 09:00:36 PDT
Comment on attachment 435484 [details] Patch not ready for review yet
Sergio Villar Senin
Comment 3 2021-08-13 10:18:12 PDT
Created attachment 435490 [details] Patch
Sergio Villar Senin
Comment 4 2021-08-16 02:11:01 PDT
Created attachment 435580 [details] Patch
Radar WebKit Bug Importer
Comment 5 2021-08-20 08:08:17 PDT
<rdar://problem/82170743>
Sergio Villar Senin
Comment 6 2021-08-26 07:25:03 PDT
Ping reviewers. It'd be nice to get this in as it's blocking another two other patches that also fix tons of tests.
Sergio Villar Senin
Comment 7 2021-08-26 07:25:28 PDT
(In reply to Sergio Villar Senin from comment #6) > Ping reviewers. It'd be nice to get this in as it's blocking another two > other patches that also fix tons of tests. Well and provide additional functionality to WebKit of course :)
Simon Fraser (smfr)
Comment 8 2021-08-26 10:37:53 PDT
Comment on attachment 435580 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435580&action=review > Source/WebCore/rendering/RenderFlexibleBox.cpp:1547 > + ASSERT_NOT_REACHED("%d alignmentForChild should have transformed this position value to something we handle below.", static_cast<uint64_t>(position)); Formatting for uint64_t would be %llu. For %d, use int.
Sergio Villar Senin
Comment 9 2021-08-31 03:00:06 PDT
Created attachment 436863 [details] Patch
Sergio Villar Senin
Comment 10 2021-09-01 01:36:05 PDT
Committed r281840 (241173@main): <https://commits.webkit.org/241173@main>
Note You need to log in before you can comment on or make changes to this bug.