Summary: | [WPE] WebExtension API test /webkit/WebKitWebView/web-process-crashed is flaky failing | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Lauro Moura <lmoura> | ||||||
Component: | WPE WebKit | Assignee: | Lauro Moura <lmoura> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bugs-noreply, cgarcia | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Lauro Moura
2021-08-12 20:30:03 PDT
I guess that's expected to happen in case of web process crash, so maybe we can just make warnings non fatal at that point or not use g_warning in wpe-fdo Created attachment 435477 [details]
Patch
(In reply to Carlos Garcia Campos from comment #1) > I guess that's expected to happen in case of web process crash, so maybe we > can just make warnings non fatal at that point or not use g_warning in > wpe-fdo Indeed. With this patch, it's consistently passing. Created attachment 435478 [details]
Patch with updated expectations
Comment on attachment 435478 [details] Patch with updated expectations View in context: https://bugs.webkit.org/attachment.cgi?id=435478&action=review > Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:166 > + Test::removeLogFatalFlag(G_LOG_LEVEL_WARNING); > g_main_loop_run(test->m_mainLoop); > + Test::addLogFatalFlag(G_LOG_LEVEL_WARNING); Ok, I think we should still check if we can remove the g_warning in wpe-fdo, because thi might hide other warnings happening. Committed r281015 (240505@main): <https://commits.webkit.org/240505@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435478 [details]. |