Bug 229059

Summary: [Web App Manifest] Always fetch the first manifest if provided
Product: WebKit Reporter: Devin Rousso <hi>
Component: New BugsAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, beidson, bfulgham, cdumez, changseok, david_quesada, eoconnor, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, hi, japhet, jensimmons, marcos, mkwst, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
bfulgham: review+, bfulgham: commit-queue-
Patch none

Description Devin Rousso 2021-08-12 17:05:20 PDT 
Right now, WebKit only fetches the web app manifest when `-[WKWebView _getApplicationManifestWithCompletionHandler:]` is called.  We should always fetch it.
Comment 1 Devin Rousso 2021-08-12 17:20:32 PDT 
Created attachment 435457 [details]
Patch
Comment 2 Devin Rousso 2021-08-12 17:51:23 PDT 
Created attachment 435459 [details]
Patch
Comment 3 Devin Rousso 2021-08-16 15:39:54 PDT 
Created attachment 435634 [details]
Patch
Comment 4 Radar WebKit Bug Importer 2021-08-19 17:06:21 PDT 
<rdar://problem/82148333>
Comment 5 Brent Fulgham 2021-09-02 09:53:17 PDT 
Comment on attachment 435634 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435634&action=review

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=229059

<rdar://82148333>

> Source/WebCore/html/HTMLLinkElement.cpp:514
> +    auto media = MediaQuerySet::create(m_media, MediaQueryParserContext(document()));

Why did you remove the LOG statement?

> Source/WebCore/loader/DocumentLoader.cpp:1566
> +        if (link.href().isEmpty() || !link.href().isValid())

HTMLLinkElement::href() looks kind of expensive. Would be good to only build it once rather than three times.
Comment 6 Devin Rousso 2021-09-02 15:49:55 PDT 
Created attachment 437205 [details]
Patch
Comment 7 EWS 2021-09-03 14:49:02 PDT 
Committed r282026 (241330@main): <https://commits.webkit.org/241330@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437205 [details].