Summary: | [GTK][WPE] Test fast/canvas/webgl/shader-with-comma-op.html and fast/canvas/webgl/shader-with-struct-array.html fail since they were added | ||
---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> |
Component: | WebGL | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | alex, bugs-noreply, dino, kbr, kkinnunen, kpiddington, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=227723 https://bugs.webkit.org/show_bug.cgi?id=226865 |
Description
Carlos Alberto Lopez Perez
2021-08-12 13:31:38 PDT
Also, likely related to the same issue, test fast/canvas/webgl/shader-with-struct-array.html fails since it was added on r279968 on GTK and WPE The text failure is: --- /home/buildbot/worker/wpe-linux-64-release-tests/build/layout-test-results/fast/canvas/webgl/shader-with-struct-array-expected.txt +++ /home/buildbot/worker/wpe-linux-64-release-tests/build/layout-test-results/fast/canvas/webgl/shader-with-struct-array-actual.txt @@ -1,10 +1,11 @@ +CONSOLE MESSAGE: TypeError: null is not an object (evaluating 'gl.createShader') Tests that program compiling/linking with a struct-array construct. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS getError was expected value: NO_ERROR : no error for struct array in program -PASS successfullyParsed is true +FAIL successfullyParsed should be true. Was false. +Some tests failed. TEST COMPLETE This two tests seems related to the Metal backend of WebGL. On Linux Metal is not supported. I wonder if the output they give is expected and we should simply skip them or there is something to fix on the WebKit Linux/WebGL backend? As a heads up, these tests were added to verify fixing the following two samples: https://bugs.webkit.org/show_bug.cgi?id=226865 Shader-with-struct-array: https://zynaps.com/content/photon/ Shader with comma-op https://bugs.webkit.org/show_bug.cgi?id=227723 https://jsfiddle.net/9p1f3t5r/2/ After replacing the WebGL backend with ANGLE these tests are fixed. The gardening commit is: https://commits.webkit.org/255008@main |