Bug 229044

Summary: Migrate Performance::resourceTimingBufferFullTimerFired to HTML event loop
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: REOPENED    
Severity: Normal CC: cdumez, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ews-feeder: commit-queue-

Alex Christensen
Reported 2021-08-12 11:06:56 PDT
Migrate Performance::resourceTimingBufferFullTimerFired to HTML event loop
Attachments
Patch (4.28 KB, patch)
2021-08-12 11:07 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (4.45 KB, patch)
2021-08-12 11:41 PDT, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-08-12 11:07:48 PDT
Created attachment 435436 [details] Patch
Geoffrey Garen
Comment 2 2021-08-12 11:22:15 PDT
Comment on attachment 435436 [details] Patch r=me
Chris Dumez
Comment 3 2021-08-12 11:22:56 PDT
Comment on attachment 435436 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435436&action=review > Source/WebCore/page/Performance.cpp:281 > ASSERT(scriptExecutionContext()); I don't think this assertion holds anymore. You probably want to switch that to an early return. The HTML event loop can fire tasks after the script execution context is gone.
Alex Christensen
Comment 4 2021-08-12 11:41:04 PDT
Created attachment 435437 [details] Patch
EWS
Comment 5 2021-08-12 12:25:11 PDT
Committed r280977 (240480@main): <https://commits.webkit.org/240480@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435437 [details].
Radar WebKit Bug Importer
Comment 6 2021-08-12 12:26:24 PDT
<rdar://problem/81862383>
Alex Christensen
Comment 7 2021-08-12 15:27:28 PDT
Reverted in r280988
Alex Christensen
Comment 8 2021-08-12 15:27:52 PDT
The change in http/tests/performance/performance-resource-timing-resourcetimingbufferfull-shrinking-buffer-crash.html definitely looks related.
Note You need to log in before you can comment on or make changes to this bug.