Bug 229033

Summary: Cherry-pick ANGLE: Fix translator fuzzer
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: ANGLEAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED INVALID    
Severity: Normal CC: dino, ews-watchlist, kbr, kkinnunen, kondapallykalyan
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 229036    
Attachments:
Description Flags
Patch
none
Patch kbr: review+

Kimmo Kinnunen
Reported 2021-08-12 04:06:13 PDT
From 2aa4f7e521a2bf0d84706403f56886047768ce3d Mon Sep 17 00:00:00 2001 From: Shahbaz Youssefi <syoussefi@chromium.org> Date: Fri, 8 Jan 2021 16:35:29 -0500 Subject: [PATCH] Fix translator fuzzer Since some ASTs are now disabled on certain conditions, this change lets the fuzzer know when it has generated invalid translator options. Makes it easier to change the file.
Attachments
Patch (6.07 KB, patch)
2021-08-12 04:08 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch (5.88 KB, patch)
2021-08-12 05:15 PDT, Kimmo Kinnunen 		kbr: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2021-08-12 04:08:54 PDT
Created attachment 435412 [details] Patch
EWS Watchlist
Comment 2 2021-08-12 04:09:46 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Kimmo Kinnunen
Comment 3 2021-08-12 05:15:30 PDT
Created attachment 435417 [details] Patch
Kenneth Russell
Comment 4 2021-08-13 15:03:48 PDT
Comment on attachment 435417 [details] Patch Since this is a cherry-pick, looks fine if you want to merge this - but in general I would prefer if we collaborated on finishing the upstreaming of the direct-to-Metal backend so that we can just roll ANGLE forward in WebKit, which should fix these fuzzer targets here. r+
Kimmo Kinnunen
Comment 5 2021-08-16 01:23:23 PDT
Thanks for checking this out. The cherry-pick is pointless if the blocking bug is r-.
Note You need to log in before you can comment on or make changes to this bug.