Bug 229012

Summary: WebKit2 can only have one active navigation policy check for a given frame
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, ews-watchlist, ggaren, japhet, kkinnunen, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=229011
https://bugs.webkit.org/show_bug.cgi?id=227924
Attachments:
Description Flags
WIP patch
none
WIP patch
none
Patch none

Chris Dumez
Reported 2021-08-11 13:34:23 PDT
WebKit2 can only have one active policy decision for a given frame. This is causing some failures / timeouts in WPT tests, in WebKit2 only.
Attachments
WIP patch (10.67 KB, patch)
2021-08-11 13:35 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP patch (7.19 KB, patch)
2021-08-11 13:38 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (13.31 KB, patch)
2021-08-11 14:31 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-08-11 13:35:49 PDT
Created attachment 435370 [details] WIP patch
Chris Dumez
Comment 2 2021-08-11 13:38:11 PDT
Created attachment 435371 [details] WIP patch
Chris Dumez
Comment 3 2021-08-11 14:31:26 PDT
Created attachment 435376 [details] Patch
Chris Dumez
Comment 4 2021-08-11 15:39:31 PDT
Comment on attachment 435376 [details] Patch Setting review flag to get a review but cq- because I will delay landing this patch until it is safe to do so.
youenn fablet
Comment 5 2021-08-13 00:15:14 PDT
Comment on attachment 435376 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435376&action=review > Source/WebKit/WebProcess/WebPage/WebFrame.cpp:221 > uint64_t WebFrame::setUpWillSubmitFormListener(CompletionHandler<void()>&& completionHandler) Would be nice to use a PolicyListenerIdentifier.
Radar WebKit Bug Importer
Comment 6 2021-08-18 13:35:27 PDT
<rdar://problem/82092066>
Chris Dumez
Comment 7 2021-08-23 07:55:21 PDT
(In reply to youenn fablet from comment #5) > Comment on attachment 435376 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=435376&action=review > > > Source/WebKit/WebProcess/WebPage/WebFrame.cpp:221 > > uint64_t WebFrame::setUpWillSubmitFormListener(CompletionHandler<void()>&& completionHandler) > > Would be nice to use a PolicyListenerIdentifier. I agree but I'll follow-up for the refactoring.
Chris Dumez
Comment 8 2021-08-23 08:02:40 PDT
Comment on attachment 435376 [details] Patch Clearing flags on attachment: 435376 Committed r281445 (240828@main): <https://commits.webkit.org/240828@main>
Chris Dumez
Comment 9 2021-08-23 08:02:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.