Bug 229012

Summary: WebKit2 can only have one active navigation policy check for a given frame
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, ews-watchlist, ggaren, japhet, kkinnunen, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=229011
https://bugs.webkit.org/show_bug.cgi?id=227924
Attachments:
Description Flags
WIP patch
none
WIP patch
none
Patch none

Description Chris Dumez 2021-08-11 13:34:23 PDT 
WebKit2 can only have one active policy decision for a given frame. This is causing some failures / timeouts in WPT tests, in WebKit2 only.
Comment 1 Chris Dumez 2021-08-11 13:35:49 PDT 
Created attachment 435370 [details]
WIP patch
Comment 2 Chris Dumez 2021-08-11 13:38:11 PDT 
Created attachment 435371 [details]
WIP patch
Comment 3 Chris Dumez 2021-08-11 14:31:26 PDT 
Created attachment 435376 [details]
Patch
Comment 4 Chris Dumez 2021-08-11 15:39:31 PDT 
Comment on attachment 435376 [details]
Patch

Setting review flag to get a review but cq- because I will delay landing this patch until it is safe to do so.
Comment 5 youenn fablet 2021-08-13 00:15:14 PDT 
Comment on attachment 435376 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435376&action=review

> Source/WebKit/WebProcess/WebPage/WebFrame.cpp:221
>  uint64_t WebFrame::setUpWillSubmitFormListener(CompletionHandler<void()>&& completionHandler)

Would be nice to use a PolicyListenerIdentifier.
Comment 6 Radar WebKit Bug Importer 2021-08-18 13:35:27 PDT 
<rdar://problem/82092066>
Comment 7 Chris Dumez 2021-08-23 07:55:21 PDT 
(In reply to youenn fablet from comment #5)
> Comment on attachment 435376 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=435376&action=review
> 
> > Source/WebKit/WebProcess/WebPage/WebFrame.cpp:221
> >  uint64_t WebFrame::setUpWillSubmitFormListener(CompletionHandler<void()>&& completionHandler)
> 
> Would be nice to use a PolicyListenerIdentifier.

I agree but I'll follow-up for the refactoring.
Comment 8 Chris Dumez 2021-08-23 08:02:40 PDT 
Comment on attachment 435376 [details]
Patch

Clearing flags on attachment: 435376

Committed r281445 (240828@main): <https://commits.webkit.org/240828@main>
Comment 9 Chris Dumez 2021-08-23 08:02:43 PDT 
All reviewed patches have been landed.  Closing bug.