Bug 228987

Summary: ANGLE Cocoa compiles contents of ContextEAGL on mac
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: ANGLEAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, kbr, kkinnunen, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kimmo Kinnunen
Reported 2021-08-11 02:20:43 PDT
ANGLE Cocoa compiles contents ContextEAGL on Mac, guards missing
Attachments
Patch (1.52 KB, patch)
2021-08-11 02:22 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2021-08-11 02:22:35 PDT
Created attachment 435330 [details] Patch
EWS Watchlist
Comment 2 2021-08-11 02:23:25 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Kenneth Russell
Comment 3 2021-08-11 12:30:13 PDT
Comment on attachment 435330 [details] Patch Looks good to me. We need to be sure to either upstream this or avoid losing it while rolling ANGLE back down into WebKit. Do you want to point to this on https://bugs.chromium.org/p/angleproject/issues/detail?id=5505 ? r+
Dean Jackson
Comment 4 2021-08-11 13:15:26 PDT
Comment on attachment 435330 [details] Patch Before we can land this - please check that it doesn't break Catalyst.
Kimmo Kinnunen
Comment 5 2021-08-11 23:29:28 PDT
Upstreaming bug: https://bugs.chromium.org/p/angleproject/issues/detail?id=6271
Kimmo Kinnunen
Comment 6 2021-08-12 05:57:48 PDT
(In reply to Dean Jackson from comment #4) > Comment on attachment 435330 [details] > Patch > > Before we can land this - please check that it doesn't break Catalyst. I checked that it compiles on Catalyst. The Catalyst doesn't yet have tests so I didn't spend time building an app to verify that WebGL works. The condition itself is same as in other files. Before, the condition was in 4 EAGL files and missing in 1 EAGL file. After, the condition was in 5 EAGL files. Based on this, I'll land.
EWS
Comment 7 2021-08-12 06:01:34 PDT
Committed r280962 (240468@main): <https://commits.webkit.org/240468@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435330 [details].
Radar WebKit Bug Importer
Comment 8 2021-08-12 06:02:19 PDT
<rdar://problem/81844871>
Note You need to log in before you can comment on or make changes to this bug.