| Summary: | ANGLE Cocoa compiles contents of ContextEAGL on mac | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> | ||||
| Component: | ANGLE | Assignee: | Kimmo Kinnunen <kkinnunen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dino, ews-watchlist, kbr, kkinnunen, kondapallykalyan, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Local Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Kimmo Kinnunen
2021-08-11 02:20:43 PDT
Created attachment 435330 [details]
Patch
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE Comment on attachment 435330 [details] Patch Looks good to me. We need to be sure to either upstream this or avoid losing it while rolling ANGLE back down into WebKit. Do you want to point to this on https://bugs.chromium.org/p/angleproject/issues/detail?id=5505 ? r+ Comment on attachment 435330 [details]
Patch
Before we can land this - please check that it doesn't break Catalyst.
Upstreaming bug: https://bugs.chromium.org/p/angleproject/issues/detail?id=6271 (In reply to Dean Jackson from comment #4) > Comment on attachment 435330 [details] > Patch > > Before we can land this - please check that it doesn't break Catalyst. I checked that it compiles on Catalyst. The Catalyst doesn't yet have tests so I didn't spend time building an app to verify that WebGL works. The condition itself is same as in other files. Before, the condition was in 4 EAGL files and missing in 1 EAGL file. After, the condition was in 5 EAGL files. Based on this, I'll land. Committed r280962 (240468@main): <https://commits.webkit.org/240468@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435330 [details]. |