Bug 228970

Summary: REGRESSION (r273072): Caps lock indicator in password field is too large
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: FormsAssignee: Aditya Keerthi <akeerthi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, webkit-bug-importer, wenson_hsieh, zalan
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=229062
Attachments:
Description Flags
Patch
none
Patch ews-feeder: commit-queue-

Aditya Keerthi
Reported 2021-08-10 14:21:04 PDT
...
Attachments
Patch (6.43 KB, patch)
2021-08-10 14:28 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Patch (8.50 KB, patch)
2021-08-10 20:07 PDT, Aditya Keerthi 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aditya Keerthi
Comment 1 2021-08-10 14:21:16 PDT
rdar://81546781
Aditya Keerthi
Comment 2 2021-08-10 14:28:09 PDT
Created attachment 435293 [details] Patch
Wenson Hsieh
Comment 3 2021-08-10 14:30:10 PDT
Comment on attachment 435293 [details] Patch r=mews
Aditya Keerthi
Comment 4 2021-08-10 14:44:14 PDT
Thanks for the review! Will wait on EWS.
Aditya Keerthi
Comment 5 2021-08-10 20:07:59 PDT
Created attachment 435319 [details] Patch
Aditya Keerthi
Comment 6 2021-08-10 20:09:10 PDT
Latest patch fixes the added test on iOS, and skips the test on WK1 due to a lack of support for toggling caps lock key state in DumpRenderTree.
EWS
Comment 7 2021-08-11 13:19:41 PDT
Committed r280927 (240445@main): <https://commits.webkit.org/240445@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435319 [details].
Note You need to log in before you can comment on or make changes to this bug.