Bug 228970 - REGRESSION (r273072): Caps lock indicator in password field is too large
Summary: REGRESSION (r273072): Caps lock indicator in password field is too large
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-10 14:21 PDT by Aditya Keerthi
Modified: 2021-08-12 17:49 PDT (History)
10 users (show)

See Also:

Attachments
Patch (6.43 KB, patch)
2021-08-10 14:28 PDT, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
Patch (8.50 KB, patch)
2021-08-10 20:07 PDT, Aditya Keerthi 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2021-08-10 14:21:04 PDT 
...
Comment 1 Aditya Keerthi 2021-08-10 14:21:16 PDT 
rdar://81546781
Comment 2 Aditya Keerthi 2021-08-10 14:28:09 PDT 
Created attachment 435293 [details]
Patch
Comment 3 Wenson Hsieh 2021-08-10 14:30:10 PDT 
Comment on attachment 435293 [details]
Patch

r=mews
Comment 4 Aditya Keerthi 2021-08-10 14:44:14 PDT 
Thanks for the review! Will wait on EWS.
Comment 5 Aditya Keerthi 2021-08-10 20:07:59 PDT 
Created attachment 435319 [details]
Patch
Comment 6 Aditya Keerthi 2021-08-10 20:09:10 PDT 
Latest patch fixes the added test on iOS, and skips the test on WK1 due to a lack of support for toggling caps lock key state in DumpRenderTree.
Comment 7 EWS 2021-08-11 13:19:41 PDT 
Committed r280927 (240445@main): <https://commits.webkit.org/240445@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435319 [details].