Summary: | typo in LayoutTests/fast/canvas/fill-stroke-clip-reset-path.html | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tony Chang <tony> | ||||||
Component: | WebKit Misc. | Assignee: | Tony Chang <tony> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Tony Chang
2008-12-16 16:40:04 PST
Created attachment 26078 [details]
[1/1] Fix typo in fill-stroke-clip-reset-path
LayoutTests/ChangeLog | 14 ++++++++++++++
.../fast/canvas/fill-stroke-clip-reset-path.html | 5 +++--
.../fill-stroke-clip-reset-path-expected.checksum | 2 +-
.../fill-stroke-clip-reset-path-expected.png | Bin 25099 -> 25179 bytes
4 files changed, 18 insertions(+), 3 deletions(-)
Comment on attachment 26078 [details]
[1/1] Fix typo in fill-stroke-clip-reset-path
LGTM. WebKit style says single line ifs don't have { } (I think that holds true even in JS).
The patch doesn't include diffs for results: Binary files a/LayoutTests/platform/mac/fast/canvas/fill-stroke-clip-reset-path-expected.png and b/LayoutTests/platform/mac/fast/canvas/fill-stroke-clip-reset-path-expected.png differ Our svn-create-patch script encodes binary files in patches, and svn-apply/svn-unapply scripts support that. Created attachment 26740 [details]
svn, not git
Updated to not add {} and include the binary diff.
Comment on attachment 26740 [details]
svn, not git
Looks good. r=me
|