Bug 22894

Summary:

typo in LayoutTests/fast/canvas/fill-stroke-clip-reset-path.html

Product:

WebKit

Reporter:

Tony Chang <tony>

Component:

WebKit Misc.

Assignee:

Tony Chang <tony>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
[1/1] Fix typo in fill-stroke-clip-reset-path	eric: review+
svn, not git	darin: review+

Tony Chang

Reported 2008-12-16 16:40:04 PST

This test tries to call layoutTestController.setUseDashboardCompatibilityMode, but actually calls layoutTestController.setUseDashboardCompatiblityMode (there's a missing 'i'). The baseline also has red as a result. Patch coming with new pixel baseline...

Attachments
[1/1] Fix typo in fill-stroke-clip-reset-path (2.54 KB, patch) 2008-12-16 16:59 PST, Tony Chang	eric: review+	Details Formatted Diff Diff
svn, not git (35.42 KB, patch) 2009-01-14 17:56 PST, Tony Chang	darin: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Tony Chang

Comment 1 2008-12-16 16:59:51 PST

Created attachment 26078 [details] [1/1] Fix typo in fill-stroke-clip-reset-path LayoutTests/ChangeLog | 14 ++++++++++++++ .../fast/canvas/fill-stroke-clip-reset-path.html | 5 +++-- .../fill-stroke-clip-reset-path-expected.checksum | 2 +- .../fill-stroke-clip-reset-path-expected.png | Bin 25099 -> 25179 bytes 4 files changed, 18 insertions(+), 3 deletions(-)

Eric Seidel (no email)

Comment 2 2009-01-06 14:01:52 PST

Comment on attachment 26078 [details] [1/1] Fix typo in fill-stroke-clip-reset-path LGTM. WebKit style says single line ifs don't have { } (I think that holds true even in JS).

Alexey Proskuryakov

Comment 3 2009-01-11 01:55:50 PST

The patch doesn't include diffs for results: Binary files a/LayoutTests/platform/mac/fast/canvas/fill-stroke-clip-reset-path-expected.png and b/LayoutTests/platform/mac/fast/canvas/fill-stroke-clip-reset-path-expected.png differ Our svn-create-patch script encodes binary files in patches, and svn-apply/svn-unapply scripts support that.

Tony Chang

Comment 4 2009-01-14 17:56:35 PST

Created attachment 26740 [details] svn, not git Updated to not add {} and include the binary diff.

Darin Adler

Comment 5 2009-01-14 18:03:42 PST

Comment on attachment 26740 [details] svn, not git Looks good. r=me

Darin Fisher (:fishd, Google)

Comment 6 2009-01-29 16:48:42 PST

http://trac.webkit.org/changeset/40388

Note You need to log in before you can comment on or make changes to this bug.