Bug 228936

Summary: Notify accessibility that WebProcess is suspended when in process cache.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Andres Gonzalez
Reported 2021-08-09 18:16:48 PDT
Notify accessibility that WebProcess is suspended when in process cache.
Attachments
Patch (3.13 KB, patch)
2021-08-09 20:17 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (3.11 KB, patch)
2021-08-09 20:42 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (5.69 KB, patch)
2021-08-10 11:32 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andres Gonzalez
Comment 1 2021-08-09 19:26:37 PDT
rdar://80911502
Andres Gonzalez
Comment 2 2021-08-09 20:17:03 PDT
Created attachment 435237 [details] Patch
Andres Gonzalez
Comment 3 2021-08-09 20:42:59 PDT
Created attachment 435239 [details] Patch
Chris Dumez
Comment 4 2021-08-10 08:19:10 PDT
Comment on attachment 435239 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435239&action=review > Source/WebKit/WebProcess/WebProcess.cpp:632 > + IPC::AccessibilityProcessSuspendedNotification(isInProcessCache); We may want to get rid of the AccessibilityProcessSuspendedNotification() that exists in WebProcessCocoa.mm now that we can call the one in IPC::Connection.
Andres Gonzalez
Comment 5 2021-08-10 11:32:42 PDT
Created attachment 435275 [details] Patch
Andres Gonzalez
Comment 6 2021-08-10 11:35:37 PDT
(In reply to Chris Dumez from comment #4) > Comment on attachment 435239 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=435239&action=review > > > Source/WebKit/WebProcess/WebProcess.cpp:632 > > + IPC::AccessibilityProcessSuspendedNotification(isInProcessCache); > > We may want to get rid of the AccessibilityProcessSuspendedNotification() > that exists in WebProcessCocoa.mm now that we can call the one in > IPC::Connection. Done. Thanks!
EWS
Comment 7 2021-08-10 14:37:27 PDT
Committed r280865 (240405@main): <https://commits.webkit.org/240405@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435275 [details].
Note You need to log in before you can comment on or make changes to this bug.