Bug 228926

Summary:

REGRESSION (r280726): [ Big Sur wk1 ] 25 imported/w3c/web-platform-tests/fetch/ failing

Product:

WebKit

Reporter:

Truitt Savell <tsavell>

Component:

New Bugs

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, eric.carlson, jer.noble, peng.liu6, thorton, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=228803
https://bugs.webkit.org/show_bug.cgi?id=228966

Attachments:

Description	Flags
Patch	none
Update comments	none
Patch	none
Patch for landing - beefed up change log	none
Rebasing	none

Description Truitt Savell 2021-08-09 15:03:31 PDT

imported/w3c/web-platform-tests/cors/304.htm [ Failure ]
  imported/w3c/web-platform-tests/fetch/api/basic/conditional-get.any.html [ Failure ]
  imported/w3c/web-platform-tests/fetch/api/basic/conditional-get.any.worker.html [ Failure ]
  imported/w3c/web-platform-tests/fetch/api/request/request-cache-default.any.html [ Failure ]
  imported/w3c/web-platform-tests/fetch/api/request/request-cache-default.any.worker.html [ Failure ]
  imported/w3c/web-platform-tests/fetch/api/request/request-cache-force-cache.any.html [ Failure ]
  imported/w3c/web-platform-tests/fetch/api/request/request-cache-force-cache.any.worker.html [ Failure ]
  imported/w3c/web-platform-tests/fetch/api/request/request-cache-only-if-cached.any.html [ Failure ]
  imported/w3c/web-platform-tests/fetch/api/request/request-cache-only-if-cached.any.worker.html [ Failure ]
  imported/w3c/web-platform-tests/fetch/api/request/request-cache-reload.any.html [ Failure ]
  imported/w3c/web-platform-tests/fetch/api/request/request-cache-reload.any.worker.html [ Failure ]
  imported/w3c/web-platform-tests/fetch/http-cache/304-update.any.html [ Failure ]
  imported/w3c/web-platform-tests/fetch/http-cache/304-update.any.worker.html [ Failure ]
  imported/w3c/web-platform-tests/fetch/http-cache/freshness.any.html [ Failure ]
  imported/w3c/web-platform-tests/fetch/http-cache/freshness.any.worker.html [ Failure ]
  imported/w3c/web-platform-tests/fetch/http-cache/heuristic.any.html [ Failure ]
  imported/w3c/web-platform-tests/fetch/http-cache/heuristic.any.worker.html [ Failure ]
  imported/w3c/web-platform-tests/fetch/http-cache/invalidate.any.html [ Failure ]
  imported/w3c/web-platform-tests/fetch/http-cache/invalidate.any.worker.html [ Failure ]
  imported/w3c/web-platform-tests/fetch/http-cache/split-cache.html [ Failure ]
  imported/w3c/web-platform-tests/fetch/http-cache/status.any.html [ Failure ]
  imported/w3c/web-platform-tests/fetch/http-cache/status.any.worker.html [ Failure ]
  imported/w3c/web-platform-tests/fetch/http-cache/vary.any.html [ Failure ]
  imported/w3c/web-platform-tests/fetch/http-cache/vary.any.worker.html [ Failure ]
  imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/credentialless/cache.tentative.html [ Failure ]

These 25 tests began failing after the changes in https://trac.webkit.org/changeset/280726/webkit

Build:
https://build.webkit.org/#/builders/48/builds/4449

Results:
https://build.webkit.org/results/Apple-BigSur-Release-WK1-Tests/r280726%20(4449)/results.html

Comment 1 Radar WebKit Bug Importer 2021-08-09 15:19:29 PDT

<rdar://problem/81715332>

Comment 2 Truitt Savell 2021-08-10 10:04:57 PDT

Also this API tests is failing sense r280726

TestWebKitAPI.AudioRoutingArbitration.Updating

History:
https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.AudioRoutingArbitration.Updating

/Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/AudioRoutingArbitration.mm:152
        Expected: (arbitrationUpdateTime) < ([webView _audioRoutingArbitrationUpdateTime]), actual: 1.62861e+09 vs 1.62861e+09
        Arbitration was not updated

Comment 3 Peng Liu 2021-08-10 12:34:10 PDT

(In reply to Truitt Savell from comment #2)
> Also this API tests is failing sense r280726
> 
> TestWebKitAPI.AudioRoutingArbitration.Updating
> 
> History:
> https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.
> AudioRoutingArbitration.Updating
> 
> /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/
> WebKitCocoa/AudioRoutingArbitration.mm:152
>         Expected: (arbitrationUpdateTime) < ([webView
> _audioRoutingArbitrationUpdateTime]), actual: 1.62861e+09 vs 1.62861e+09
>         Arbitration was not updated

File bug 228966 to track this failure.

Comment 4 Peng Liu 2021-08-10 12:47:52 PDT

Created attachment 435282 [details]
Patch

Comment 5 Peng Liu 2021-08-10 15:20:40 PDT

Created attachment 435305 [details]
Update comments

Comment 6 EWS 2021-08-10 23:10:34 PDT

Committed r280884 (240421@main): <https://commits.webkit.org/240421@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435305 [details].

Comment 7 Peng Liu 2021-08-10 23:12:00 PDT

Reopen this bug because the issue has not been resolved yet.

Comment 8 youenn fablet 2021-08-11 06:55:14 PDT

Created attachment 435340 [details]
Patch

Comment 9 youenn fablet 2021-08-12 01:32:25 PDT

Created attachment 435402 [details]
Patch for landing - beefed up change log

Comment 10 youenn fablet 2021-08-12 02:45:46 PDT

Not sure why AS EWS bot is not happy with the patch it used to be happy with yesterday. Let's land it and I'll revert it if builders are not happy with it.

Comment 11 youenn fablet 2021-08-12 02:53:54 PDT

Created attachment 435405 [details]
Rebasing

Comment 12 EWS 2021-08-12 04:44:03 PDT

Committed r280961 (240467@main): <https://commits.webkit.org/240467@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435405 [details].

Comment 13 Alexey Proskuryakov 2021-08-12 10:19:05 PDT

Comment on attachment 435405 [details]
Rebasing

View in context: https://bugs.webkit.org/attachment.cgi?id=435405&action=review

> Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm:52
> +#if PLATFORM(MAC)

Does this do the right thing for macCatalyst?

Comment 14 Peng Liu 2021-08-12 10:51:43 PDT

Comment on attachment 435405 [details]
Rebasing

View in context: https://bugs.webkit.org/attachment.cgi?id=435405&action=review

>> Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm:52
>> +#if PLATFORM(MAC)
> 
> Does this do the right thing for macCatalyst?

Confirmed with Tim. This patch is correct. macCatalyst will use the #else branch as expected.

Comment 15 Tim Horton 2021-08-12 11:02:45 PDT

(In reply to Peng Liu from comment #14)
> Comment on attachment 435405 [details]
> Rebasing
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=435405&action=review
> 
> >> Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm:52
> >> +#if PLATFORM(MAC)
> > 
> > Does this do the right thing for macCatalyst?
> 
> Confirmed with Tim. This patch is correct. macCatalyst will use the #else
> branch as expected.

"Correct" is a strong word :) But it doesn't /matter/.

Comment 16 Tim Horton 2021-08-12 11:03:52 PDT

(In reply to Tim Horton from comment #15)
> (In reply to Peng Liu from comment #14)
> > Comment on attachment 435405 [details]
> > Rebasing
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=435405&action=review
> > 
> > >> Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm:52
> > >> +#if PLATFORM(MAC)
> > > 
> > > Does this do the right thing for macCatalyst?
> > 
> > Confirmed with Tim. This patch is correct. macCatalyst will use the #else
> > branch as expected.
> 
> "Correct" is a strong word :) But it doesn't /matter/.

(except for local builds)