| Summary: | CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::CryptoKeyRSA::exportJwk const | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kate Cheney <katherine_cheney> | ||||
| Component: | New Bugs | Assignee: | Kate Cheney <katherine_cheney> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, ddkilzer, ews-watchlist, jiewen_tan, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Kate Cheney
2021-08-06 14:59:28 PDT
Created attachment 435093 [details]
Patch
Comment on attachment 435093 [details]
Patch
R=me
Comment on attachment 435093 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435093&action=review > Source/WebCore/crypto/keys/CryptoKeyRSA.cpp:143 > + return result; Should we log anything here? I assume JsonWebKey initialized these values appropriately? Comment on attachment 435093 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435093&action=review >> Source/WebCore/crypto/keys/CryptoKeyRSA.cpp:143 >> + return result; > > Should we log anything here? I assume JsonWebKey initialized these values appropriately? The exportData() function logs anytime it returns nullptr, so I think extra logging here would be unnecessary. It probably is a good idea to investigate why CCRSAGetKeyComponents is failing sometimes and causing rsaComponents to be null, though. Committed r280747 (240333@main): <https://commits.webkit.org/240333@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435093 [details]. Layout test failures are in web animations and seem super unrelated. |