Bug 228852

Summary:

Add deduction guide to RetainPtr, use constexpr a bit more, and streamline the implementation

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

Web Template Framework

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, ews-watchlist, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Darin Adler 2021-08-05 18:12:12 PDT

Add deduction guide to RetainPtr, use constexpr a bit more, and streamline the implementation

Comment 1 Darin Adler 2021-08-05 18:21:16 PDT

Created attachment 435044 [details]
Patch

Comment 2 Darin Adler 2021-08-09 15:33:21 PDT

Comment on attachment 435044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435044&action=review

> Source/WebKit/UIProcess/mac/WKTextFinderClient.mm:230
>      _findReplyCallbacks.append([progress, copiedResultCollector] (NSArray *matches, bool didWrap) {

Just realized this should move the progress in, instead of copying.

Comment 3 EWS 2021-08-11 19:08:15 PDT

Committed r280952 (240458@main): <https://commits.webkit.org/240458@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435044 [details].

Comment 4 Radar WebKit Bug Importer 2021-08-11 19:09:18 PDT

<rdar://problem/81824803>

Comment 5 Chris Dumez 2021-08-12 08:54:31 PDT

Follow-up build fix: https://commits.webkit.org/240475@main