Bug 228834

Summary: [macOS] 3 second IPC deadlocks involving WebPageProxy::acceptsFirstMouse
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: WebKit Misc.Assignee: Aditya Keerthi <akeerthi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
Patch for landing none

Description Aditya Keerthi 2021-08-05 10:14:02 PDT 
...
Comment 1 Aditya Keerthi 2021-08-05 10:14:24 PDT 
rdar://75390908
Comment 2 Aditya Keerthi 2021-08-05 10:17:32 PDT 
Created attachment 435000 [details]
Patch
Comment 3 Wenson Hsieh 2021-08-06 12:56:51 PDT 
Comment on attachment 435000 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435000&action=review

Looks good to me, but it would be good to have some input from Chris or Tim too.

> Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:402
>      const Seconds messageTimeout(3);

Nit - perhaps we can take this opportunity to just turn this into `3_s`?
Comment 4 Aditya Keerthi 2021-08-06 13:32:37 PDT 
Created attachment 435082 [details]
Patch for landing
Comment 5 Aditya Keerthi 2021-08-06 13:33:10 PDT 
(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 435000 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=435000&action=review
> 
> Looks good to me, but it would be good to have some input from Chris or Tim
> too.
> 
> > Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:402
> >      const Seconds messageTimeout(3);
> 
> Nit - perhaps we can take this opportunity to just turn this into `3_s`?

Done.
Comment 6 EWS 2021-08-06 14:59:22 PDT 
Committed r280736 (240322@main): <https://commits.webkit.org/240322@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435082 [details].