Bug 228834 - [macOS] 3 second IPC deadlocks involving WebPageProxy::acceptsFirstMouse
Summary: [macOS] 3 second IPC deadlocks involving WebPageProxy::acceptsFirstMouse
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-05 10:14 PDT by Aditya Keerthi
Modified: 2021-08-06 14:59 PDT (History)
4 users (show)

See Also:

Attachments
Patch (15.29 KB, patch)
2021-08-05 10:17 PDT, Aditya Keerthi 		thorton: review+
Details | Formatted Diff | Diff
Patch for landing (15.27 KB, patch)
2021-08-06 13:32 PDT, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2021-08-05 10:14:02 PDT 
...
Comment 1 Aditya Keerthi 2021-08-05 10:14:24 PDT 
rdar://75390908
Comment 2 Aditya Keerthi 2021-08-05 10:17:32 PDT 
Created attachment 435000 [details]
Patch
Comment 3 Wenson Hsieh 2021-08-06 12:56:51 PDT 
Comment on attachment 435000 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435000&action=review

Looks good to me, but it would be good to have some input from Chris or Tim too.

> Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:402
>      const Seconds messageTimeout(3);

Nit - perhaps we can take this opportunity to just turn this into `3_s`?
Comment 4 Aditya Keerthi 2021-08-06 13:32:37 PDT 
Created attachment 435082 [details]
Patch for landing
Comment 5 Aditya Keerthi 2021-08-06 13:33:10 PDT 
(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 435000 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=435000&action=review
> 
> Looks good to me, but it would be good to have some input from Chris or Tim
> too.
> 
> > Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:402
> >      const Seconds messageTimeout(3);
> 
> Nit - perhaps we can take this opportunity to just turn this into `3_s`?

Done.
Comment 6 EWS 2021-08-06 14:59:22 PDT 
Committed r280736 (240322@main): <https://commits.webkit.org/240322@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435082 [details].