RESOLVED FIXED228834
[macOS] 3 second IPC deadlocks involving WebPageProxy::acceptsFirstMouse 
https://bugs.webkit.org/show_bug.cgi?id=228834
Summary [macOS] 3 second IPC deadlocks involving WebPageProxy::acceptsFirstMouse
Aditya Keerthi
Reported 2021-08-05 10:14:02 PDT
...
Attachments
Patch (15.29 KB, patch)
2021-08-05 10:17 PDT, Aditya Keerthi 		thorton: review+
DetailsFormatted DiffDiff
Patch for landing (15.27 KB, patch)
2021-08-06 13:32 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aditya Keerthi
Comment 1 2021-08-05 10:14:24 PDT
rdar://75390908
Aditya Keerthi
Comment 2 2021-08-05 10:17:32 PDT
Created attachment 435000 [details] Patch
Wenson Hsieh
Comment 3 2021-08-06 12:56:51 PDT
Comment on attachment 435000 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435000&action=review Looks good to me, but it would be good to have some input from Chris or Tim too. > Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:402 > const Seconds messageTimeout(3); Nit - perhaps we can take this opportunity to just turn this into `3_s`?
Aditya Keerthi
Comment 4 2021-08-06 13:32:37 PDT
Created attachment 435082 [details] Patch for landing
Aditya Keerthi
Comment 5 2021-08-06 13:33:10 PDT
(In reply to Wenson Hsieh from comment #3) > Comment on attachment 435000 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=435000&action=review > > Looks good to me, but it would be good to have some input from Chris or Tim > too. > > > Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:402 > > const Seconds messageTimeout(3); > > Nit - perhaps we can take this opportunity to just turn this into `3_s`? Done.
EWS
Comment 6 2021-08-06 14:59:22 PDT
Committed r280736 (240322@main): <https://commits.webkit.org/240322@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435082 [details].
Note You need to log in before you can comment on or make changes to this bug.