Bug 228832

Summary: Implement no-quirks mode for media/plugin/ua-inline documents
Product: WebKit Reporter: Mason Freed <masonfreed>
Component: DOMAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, ahmad.saleem792, andresg_22, apinheiro, ap, bfulgham, cdumez, cfleizach, changseok, dmazzoni, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, japhet, jcraig, jdiggs, jer.noble, philipj, rniwa, samuel_white, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=244950
Bug Depends on: 244950    
Bug Blocks:    
Attachments:
Description Flags
WIP patch
ews-feeder: commit-queue-
WIP patch
none
WIP patch
ews-feeder: commit-queue-
WIP patch
none
WIP patch ews-feeder: commit-queue-

Description Mason Freed 2021-08-05 08:59:06 PDT 
The spec has recently changed for these document types, to indicate that they should be standards-mode documents instead of quirks-mode documents.

https://github.com/whatwg/html/pull/6745

The implementation should change accordingly.

These three WPTs test some of this behavior:
https://wpt.fyi/results/html/browsers/browsing-the-web/read-media/pageload-video.html
https://wpt.fyi/results/html/browsers/browsing-the-web/read-media/pageload-image.html
https://wpt.fyi/results/html/browsers/browsing-the-web/read-text/load-text-plain.html
Comment 1 Radar WebKit Bug Importer 2021-08-12 09:00:16 PDT 
<rdar://problem/81851619>
Comment 2 Chris Dumez 2021-08-27 14:01:35 PDT 
Created attachment 436671 [details]
WIP patch
Comment 3 Chris Dumez 2021-08-27 15:51:36 PDT 
Created attachment 436686 [details]
WIP patch
Comment 4 Chris Dumez 2021-08-27 16:27:43 PDT 
Created attachment 436689 [details]
WIP patch
Comment 5 Chris Dumez 2021-08-30 09:59:35 PDT 
Created attachment 436787 [details]
WIP patch
Comment 6 Chris Dumez 2021-08-30 10:26:08 PDT 
Created attachment 436791 [details]
WIP patch
Comment 7 Ahmad Saleem 2022-08-10 09:38:23 PDT 
From the test cases in Comment 0:

Test 1 - Only Firefox pass this test as of right now.

Test 2 - Only Safari fail this test.

Test 3 - Safari fail one of the test and it is only browsers failing this test. All browsers (Chrome Canary 106 and Firefox Nightly 105) pass all tests.

Just wanted to share updated status. Thanks!
Comment 8 Brent Fulgham 2022-09-12 11:48:47 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4272
Comment 9 EWS 2022-09-15 12:34:55 PDT 
Committed 254526@main (fcbca01158eb): <https://commits.webkit.org/254526@main>

Reviewed commits have been landed. Closing PR #4272 and removing active labels.