Bug 228825

Summary: [MSE][GStreamer] Update tracks synchronously
Product: WebKit Reporter: Alicia Boya García <aboya>
Component: WebKitGTKAssignee: Alicia Boya García <aboya>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, jer.noble, menard, philipj, pnormand, sergio, vjaquez
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=229063
Attachments:
Description Flags
Patch none

Description Alicia Boya García 2021-08-05 06:53:30 PDT 
A mistake introduced with the WebKitMediaSrc v2 patch made the call to
updateTracks() in MediaPlayerPrivateGStreamer asynchronous.

This introduced a subtle race condition in which the "resize" event
may be handled before updateTracks() is called, therefore m_hasVideo
has not yet been set to true, and querying the video size from the
"resize" event handler returns 0x0.

This fixes a timeout flake in media/media-source/media-source-resize.html.
Comment 1 Alicia Boya García 2021-08-05 06:54:26 PDT 
Created attachment 434983 [details]
Patch
Comment 2 EWS 2021-08-09 06:11:02 PDT 
Committed r280775 (240359@main): <https://commits.webkit.org/240359@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434983 [details].