Bug 228816

Summary: MediaPlayerPrivateMediaStreamAVFObjC should skip enqueuing frames when not visible
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, kondapallykalyan, pdr, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2021-08-05 03:09:27 PDT
MediaPlayerPrivateMediaStreamAVFObjC should skip enqueuing frames when not visible
Attachments
Patch (16.77 KB, patch)
2021-08-05 03:24 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (16.76 KB, patch)
2021-08-05 10:53 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-08-05 03:10:59 PDT
<rdar://81077972>
youenn fablet
Comment 2 2021-08-05 03:24:45 PDT
Created attachment 434974 [details] Patch
Eric Carlson
Comment 3 2021-08-05 09:38:47 PDT
Comment on attachment 434974 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434974&action=review > Source/WebCore/ChangeLog:11 > + We do this by stopping to call ensureLayers when getting a new track. Instead we react upon player renderingCanBeAccelerated value. s/by stopping to call/by not calling/ > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:611 > -void MediaPlayerPrivateMediaStreamAVFObjC::setVisible(bool visible) > +void MediaPlayerPrivateMediaStreamAVFObjC::setVisible(bool isVisible) Not new to this patch, but we might want to rename this to `setPageIsVisible`, or maybe `setViewportIsVisible`, to match the names of the other "visible" methods.
youenn fablet
Comment 4 2021-08-05 10:49:04 PDT
(In reply to Eric Carlson from comment #3) > Comment on attachment 434974 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=434974&action=review > > > Source/WebCore/ChangeLog:11 > > + We do this by stopping to call ensureLayers when getting a new track. Instead we react upon player renderingCanBeAccelerated value. > > s/by stopping to call/by not calling/ > > > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:611 > > -void MediaPlayerPrivateMediaStreamAVFObjC::setVisible(bool visible) > > +void MediaPlayerPrivateMediaStreamAVFObjC::setVisible(bool isVisible) > > Not new to this patch, but we might want to rename this to > `setPageIsVisible`, or maybe `setViewportIsVisible`, to match the names of > the other "visible" methods. Thanks for the review, I'll do that renaming in a follow-up: https://bugs.webkit.org/show_bug.cgi?id=228837
youenn fablet
Comment 5 2021-08-05 10:53:07 PDT
Created attachment 435006 [details] Patch for landing
EWS
Comment 6 2021-08-06 02:15:58 PDT
Committed r280720 (240311@main): <https://commits.webkit.org/240311@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435006 [details].
Note You need to log in before you can comment on or make changes to this bug.