Bug 228807

Summary:

[macOS Monterey] Translate popover becomes detached from webpage after scrolling

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

Platform

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hi, luming_yin, megan_gardner, sam, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Wenson Hsieh 2021-08-04 17:39:40 PDT

rdar://81540115

Comment 1 Wenson Hsieh 2021-08-04 19:24:40 PDT

Created attachment 434961 [details]
Patch

Comment 2 Sam Weinig 2021-08-05 08:00:59 PDT

Can we make a test for this?

Comment 3 Wenson Hsieh 2021-08-05 08:28:24 PDT

Thanks for the review!

(In reply to Sam Weinig from comment #2)
> Can we make a test for this?

That's a good question.. It should be possible, but it might be somewhat tricky to make it listen for popover presentation hooks. We could naively observe NSPopoverDidShowNotification and NSPopoverDidCloseNotification, but I'm not sure that will be robust in the case where we have multiple test runners attempting to present popovers simultaneously.

I'll experiment with this: filed https://webkit.org/b/228829.

Comment 4 EWS 2021-08-05 09:03:43 PDT

Committed r280690 (240292@main): <https://commits.webkit.org/240292@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434961 [details].