WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
228807
[macOS Monterey] Translate popover becomes detached from webpage after scrolling
https://bugs.webkit.org/show_bug.cgi?id=228807
Summary
[macOS Monterey] Translate popover becomes detached from webpage after scrolling
Wenson Hsieh
Reported
2021-08-04 17:39:40 PDT
rdar://81540115
Attachments
Patch
(4.62 KB, patch)
2021-08-04 19:24 PDT
,
Wenson Hsieh
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Wenson Hsieh
Comment 1
2021-08-04 19:24:40 PDT
Created
attachment 434961
[details]
Patch
Sam Weinig
Comment 2
2021-08-05 08:00:59 PDT
Can we make a test for this?
Wenson Hsieh
Comment 3
2021-08-05 08:28:24 PDT
Thanks for the review! (In reply to Sam Weinig from
comment #2
)
> Can we make a test for this?
That's a good question.. It should be possible, but it might be somewhat tricky to make it listen for popover presentation hooks. We could naively observe NSPopoverDidShowNotification and NSPopoverDidCloseNotification, but I'm not sure that will be robust in the case where we have multiple test runners attempting to present popovers simultaneously. I'll experiment with this: filed
https://webkit.org/b/228829
.
EWS
Comment 4
2021-08-05 09:03:43 PDT
Committed
r280690
(
240292@main
): <
https://commits.webkit.org/240292@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 434961
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug