Bug 228777

Summary:

Remove unneeded sandbox extension code

Product:

WebKit

Reporter:

Per Arne Vollan <pvollan>

Component:

WebKit Misc.

Assignee:

Jean-Yves Avenard [:jya] <jean-yves.avenard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, eric.carlson, gavin.p, ggaren, jean-yves.avenard, jer.noble, mazander, peng.liu6, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=239308

Attachments:

Description	Flags
Patch	none
Patch	bfulgham: review+

Description Per Arne Vollan 2021-08-04 08:54:24 PDT

Since the GPU process is now enabled by default, some related sandbox extension code can be removed.

Comment 1 Radar WebKit Bug Importer 2021-08-04 08:55:16 PDT

<rdar://problem/81516828>

Comment 2 Per Arne Vollan 2021-08-04 08:56:49 PDT

Created attachment 434906 [details]
Patch

Comment 3 Brent Fulgham 2021-08-30 16:44:21 PDT

Comment on attachment 434906 [details]
Patch

Should we hold off on this until the GPU Process team is confident they don't need to debug or A/B test anymore?

Comment 4 Per Arne Vollan 2021-08-31 07:32:33 PDT

(In reply to Brent Fulgham from comment #3)
> Comment on attachment 434906 [details]
> Patch
> 
> Should we hold off on this until the GPU Process team is confident they
> don't need to debug or A/B test anymore?

That is a good point. I think we may hold off a little while longer.

Thanks for reviewing!

Comment 5 Per Arne Vollan 2022-02-07 10:02:23 PST

Created attachment 451119 [details]
Patch

Comment 6 Jean-Yves Avenard [:jya] 2022-02-07 12:37:33 PST

Comment on attachment 451119 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451119&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:-8204
> -        "com.apple.audio.AudioComponentPrefs"_s, "com.apple.audio.AudioComponentRegistrar"_s,

Will this break webaudio that is happening in the content process?

Comment 7 Per Arne Vollan 2022-02-07 12:59:34 PST

(In reply to Jean-Yves Avenard [:jya] from comment #6)
> Comment on attachment 451119 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=451119&action=review
> 
> > Source/WebKit/UIProcess/WebPageProxy.cpp:-8204
> > -        "com.apple.audio.AudioComponentPrefs"_s, "com.apple.audio.AudioComponentRegistrar"_s,
> 
> Will this break webaudio that is happening in the content process?

I don't believe it will, since we only create these sandbox extensions if Media in GPUP is not enabled.

Thanks for reviewing!

Comment 8 Brent Fulgham 2022-02-18 14:35:58 PST

Comment on attachment 451119 [details]
Patch

r=me

Comment 9 Per Arne Vollan 2022-02-18 14:45:48 PST

(In reply to Brent Fulgham from comment #8)
> Comment on attachment 451119 [details]
> Patch
> 
> r=me

Thanks for reviewing!

Comment 10 Per Arne Vollan 2022-02-18 16:27:09 PST

Committed r290183 (?): <https://commits.webkit.org/r290183>

Comment 11 Jean-Yves Avenard [:jya] 2022-05-05 09:15:14 PDT

Re-opening for pull request https://github.com/WebKit/WebKit/pull/525