Bug 228744
Summary: | REGRESSION (r280541): [ BigSur Debug ] accessibility/roles-computedRoleString.html is timing out | ||
---|---|---|---|
Product: | WebKit | Reporter: | ayumi_kojima |
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
Status: | CLOSED FIXED | ||
Severity: | Normal | CC: | cdumez, cfleizach, webkit-bot-watchers-bugzilla, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
ayumi_kojima
accessibility/roles-computedRoleString.html
Is timing out on BigSur Debug.
History: https://results.webkit.org/?suite=layout-tests&test=accessibility%2Froles-computedRoleString.html
No diff is available.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/81472432>
ayumi_kojima
I was able to reproduce the timeout using:
run-webkit-tests --iterations 50 --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 --debug accessibility/roles-computedRoleString.html
Though regression point is clear according to the history, test timed out at TOT, r280534 (seemingly regression started), r280531 (before regression), r279828 (one revision prior to the last change in the test).
ayumi_kojima
Updated test expectations while investing https://trac.webkit.org/changeset/280636/webkit
ayumi_kojima
It looks like the timeout started at https://trac.webkit.org/changeset/280541/webkit
Chris Dumez
Committed r280649 (240260@main): <https://commits.webkit.org/240260@main>
Ryan Haddad
It appears that this is resolved for Apple Silicon machines, but the test is still timing out on Intel bots.
Chris Dumez
Reopening as it seems this is still happening.
Chris Dumez
I can reproduce the time out locally. Reverting r280541 does not fix the timeout for me though. As a matter of fact, I don't even see setInnerText() getting called during that test.
I am not sure we have the regression point right.
Chris Dumez
It looks like the test is very slow. This is why it only times out on debug bots and only on some hardware. I took a trace and we seems to be spending a lot of time under AXLogger::log() (which ends up calling Element::outerHTML()).
r280541 probably slowed down setInnerText a bit and it caused the test to time out. In r280649, I updated the test to stop using setInnerText and it made the test a bit faster, allowing it to pass on some hardware but not all.
Chris Dumez
Committed r280708 (240303@main): <https://commits.webkit.org/240303@main>