Bug 228742

Summary: REGRESSION (r280531): [ BigSur ] 17 media/modern-media-controls/* tests are flaky timing out
Product: WebKit Reporter: ayumi_kojima
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Test List none

Description ayumi_kojima 2021-08-03 11:13:50 PDT
media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-on.html
media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-off.html
media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-on-audio.html
media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-toggle.html
media/modern-media-controls/media-controller/media-controller-fullscreen-ltr.html
media/modern-media-controls/media-controller/media-controller-resize.html
media/modern-media-controls/media-controller/media-controller-controls-sizing-with-border-and-padding.html
media/modern-media-controls/mute-support/mute-support-media-api.html
media/modern-media-controls/placard-support/placard-support-error-recover.html
media/modern-media-controls/start-support/start-support-manual-play.html
media/modern-media-controls/start-support/start-support-fullscreen.html
media/modern-media-controls/start-support/start-support-click-to-start.html
media/modern-media-controls/volume-support/volume-support-media-api.html
media/modern-media-controls/volume-support/volume-support-media-api-mute.html

Are flaky timing out on BigSur. 

Though how flaky the timeouts are and where the timeouts are seen (Debug vs Release, wk 1 vs wk2, Intel vs arm64 ) vary depending on the tests, they all have a very similar pattern in that the flaky timeouts seem to have started at around the same time. 

History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=media%2Fmodern-media-controls%2Fmedia-controller%2Fmedia-controller-fullscreen-ltr.html&test=media%2Fmodern-media-controls%2Fstart-support%2Fstart-support-click-to-start.html&test=media%2Fmodern-media-controls%2Fvolume-support%2Fvolume-support-media-api.html&test=media%2Fmodern-media-controls%2Fmedia-controller%2Fmedia-controller-controls-sizing-with-border-and-padding.html&test=media%2Fmodern-media-controls%2Fplacard-support%2Fplacard-support-error-recover.html&test=media%2Fmodern-media-controls%2Fcontrols-visibility-support%2Fcontrols-visibility-support-controls-on-audio.html&test=media%2Fmodern-media-controls%2Fmedia-controller%2Fmedia-controller-resize.html&test=media%2Fmodern-media-controls%2Fvolume-support%2Fvolume-support-media-api-mute.html&test=media%2Fmodern-media-controls%2Fstart-support%2Fstart-support-fullscreen.html&test=media%2Fmodern-media-controls%2Fcontrols-visibility-support%2Fcontrols-visibility-support-controls-on.html&test=media%2Fmodern-media-controls%2Fmute-support%2Fmute-support-media-api.html&test=media%2Fmodern-media-controls%2Fstart-support%2Fstart-support-manual-play.html&test=media%2Fmodern-media-controls%2Fcontrols-visibility-support%2Fcontrols-visibility-support-controls-toggle.html&test=media%2Fmodern-media-controls%2Fcontrols-visibility-support%2Fcontrols-visibility-support-controls-off.html

Diff:

--- /Volumes/Data/worker/bigsur-release-applesilicon-tests-wk2/build/layout-test-results/media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-off-expected.txt
+++ /Volumes/Data/worker/bigsur-release-applesilicon-tests-wk2/build/layout-test-results/media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-off-actual.txt
@@ -1,15 +1,5 @@
-Testing the ControlsVisibilitySupport behavior without controls.
+#PID UNRESPONSIVE - WebKitTestRunner (pid 84535)
+FAIL: Timed out waiting for notifyDone to be called
 
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-Media has not begun loading yet
-PASS mediaController.controls.visible is false
-
-Media has loaded metadata
-PASS mediaController.controls.visible is false
-
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
+#EOF
+#EOF

Result page: https://build.webkit.org/results/Apple-BigSur-Release-AppleSilicon-WK2-Tests/r280589%20(3004)/results.html
Comment 1 Radar WebKit Bug Importer 2021-08-03 11:21:05 PDT
<rdar://problem/81471146>
Comment 2 ayumi_kojima 2021-08-03 11:21:34 PDT
It seems that the timeouts have started at https://trac.webkit.org/changeset/280531/webkit
Comment 3 ayumi_kojima 2021-08-03 11:30:24 PDT
media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-off-audio.html
media/modern-media-controls/playback-support/playback-support-media-api.html
media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html

Are also timing out on BigSur. Seems like the same timeouts as the other media/modern-media-controls tests.

History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&test=media%2Fmodern-media-controls%2Fcontrols-visibility-support%2Fcontrols-visibility-support-controls-off-audio.html&test=media%2Fmodern-media-controls%2Fplayback-support%2Fplayback-support-media-api.html&test=media%2Fmodern-media-controls%2Ffullscreen-support%2Ffullscreen-support-enabled.html
Comment 4 ayumi_kojima 2021-08-03 11:35:41 PDT
Created attachment 434844 [details]
Test List
Comment 5 ayumi_kojima 2021-08-03 11:36:18 PDT
I was not able to reproduce the timeout using: 

run-webkit-tests --iterations 1000 --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-off.html

run-webkit-tests --iterations 2 --exit-after-n-failures 100 --exit-after-n-crashes-or-timeouts 100  --test-list [testlist] --child-processes 1

Test list is attached above.
Comment 6 ayumi_kojima 2021-08-03 11:58:53 PDT

*** This bug has been marked as a duplicate of bug 228714 ***