Bug 228722

Summary:

[Live Text] [iOS] Provide a presenting `UIViewController` for machine readable code actions so that they are related to the same view

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Platform

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, hi, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Devin Rousso 2021-08-02 16:19:42 PDT

Comment 1 Devin Rousso 2021-08-02 16:20:43 PDT

Created attachment 434798 [details]
Patch

Comment 2 Devin Rousso 2021-08-02 16:21:31 PDT

<rdar://problem/81178584>

Comment 3 Tim Horton 2021-08-02 17:05:38 PDT

Comment on attachment 434798 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434798&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:10161
> +static UIViewController *viewControllerForView(UIView *view)

Pretty sure we have a canonical implementation of this that also lets the client give you a more appropriate VC, might want to find that and use it instead.

Comment 4 Tim Horton 2021-08-02 17:09:35 PDT

Specifically referring to _viewControllerForFullScreenPresentationFromView

Comment 5 Devin Rousso 2021-08-02 19:12:44 PDT

Created attachment 434808 [details]
Patch

Comment 6 EWS 2021-08-03 11:22:54 PDT

Committed r280603 (240221@main): <https://commits.webkit.org/240221@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434808 [details].