Bug 228722

Summary: [Live Text] [iOS] Provide a presenting `UIViewController` for machine readable code actions so that they are related to the same view
Product: WebKit Reporter: Devin Rousso <hi>
Component: PlatformAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, hi, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2021-08-02 16:19:42 PDT
.
Attachments
Patch (5.29 KB, patch)
2021-08-02 16:20 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (4.95 KB, patch)
2021-08-02 19:12 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2021-08-02 16:20:43 PDT
Created attachment 434798 [details] Patch
Devin Rousso
Comment 2 2021-08-02 16:21:31 PDT
<rdar://problem/81178584>
Tim Horton
Comment 3 2021-08-02 17:05:38 PDT
Comment on attachment 434798 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434798&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:10161 > +static UIViewController *viewControllerForView(UIView *view) Pretty sure we have a canonical implementation of this that also lets the client give you a more appropriate VC, might want to find that and use it instead.
Tim Horton
Comment 4 2021-08-02 17:09:35 PDT
Specifically referring to _viewControllerForFullScreenPresentationFromView
Devin Rousso
Comment 5 2021-08-02 19:12:44 PDT
Created attachment 434808 [details] Patch
EWS
Comment 6 2021-08-03 11:22:54 PDT
Committed r280603 (240221@main): <https://commits.webkit.org/240221@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434808 [details].
Note You need to log in before you can comment on or make changes to this bug.