| Summary: | [COOP] Cross-Origin-Opener-Policy header parsing fails when report-to parameter is present | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
| Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, darin, ggaren, rniwa, sam, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 228755 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Chris Dumez
2021-08-02 15:15:03 PDT
Created attachment 434793 [details]
Patch
Comment on attachment 434793 [details]
Patch
r=me
Comment on attachment 434793 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434793&action=review > Source/WebCore/platform/network/HTTPParsers.cpp:634 > + value = header.substring(valueStart, index - valueStart).toStringWithoutCopying(); Not new, but "without copying" here does not seem right, since we move this value into a map and then return it. Why is it OK to not copy? Comment on attachment 434793 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434793&action=review >> Source/WebCore/platform/network/HTTPParsers.cpp:634 >> + value = header.substring(valueStart, index - valueStart).toStringWithoutCopying(); > > Not new, but "without copying" here does not seem right, since we move this value into a map and then return it. Why is it OK to not copy? Yes, this looks risky. I'll use toString(). Created attachment 434812 [details]
Patch
Created attachment 434813 [details]
Patch
Committed r280582 (240204@main): <https://commits.webkit.org/240204@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434813 [details]. |