Bug 228701

Summary: [PlayStation] Make C files in testapi compile with a C standard rather than C++ one
Product: WebKit Reporter: Stephan Szabo <stephan.szabo>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, msaboff, ross.kirsling, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Stephan Szabo
Reported 2021-08-02 09:05:43 PDT
Building of testapi for playstation using Visual Studio started to fail for me complaining about having the argument to use c++17 as the standard for the .C files. We've seen this before and generally add either a compile as C++ or use an appropriate standard in our PlatformPlayStation.cmake.
Attachments
Patch (1.50 KB, patch)
2021-08-02 09:28 PDT, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Stephan Szabo
Comment 1 2021-08-02 09:28:06 PDT
Created attachment 434759 [details] Patch
Ross Kirsling
Comment 2 2021-08-02 12:04:28 PDT
Comment on attachment 434759 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434759&action=review r=me > Source/JavaScriptCore/shell/PlatformPlayStation.cmake:34 > + PROPERTIES COMPILE_FLAGS --std=gnu17 I take it the GNU extensions are needed?
Stephan Szabo
Comment 3 2021-08-02 12:20:03 PDT
Yes - something included tries to do some inline assembly which is unhappy in plain C mode.
EWS
Comment 4 2021-08-02 16:39:17 PDT
Committed r280569 (240193@main): <https://commits.webkit.org/240193@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434759 [details].
Radar WebKit Bug Importer
Comment 5 2021-08-02 16:40:17 PDT
<rdar://problem/81435038>
Note You need to log in before you can comment on or make changes to this bug.