Bug 228691

Summary:

Skip unnecessary invalidation of document level NodeList caches

Product:

WebKit

Reporter:

Maciej Stachowiak <mjs>

Component:

New Bugs

Assignee:

Maciej Stachowiak <mjs>

Status:

NEW ---

Severity:

Normal

CC:

cdumez, darin, esprehn+autocc, ews-watchlist, kangil.han, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
For EWS testing only	mjs: commit-queue-

Description Maciej Stachowiak 2021-08-01 14:55:19 PDT

Skip unnecessary invalidation of document level NodeList caches

Comment 1 Maciej Stachowiak 2021-08-01 14:56:46 PDT

Created attachment 434727 [details]
For EWS testing only

Comment 2 Maciej Stachowiak 2021-08-01 14:58:53 PDT

Comment on attachment 434727 [details]
For EWS testing only

Not for landing. This version of the patch is like incorrect, as some NodeLists or Collections may need document-level invalidation even when the node isn't in the document. This is probably true for HTMLFormControlCollection, not clear what else may be affected. Testing if this builds and passes tests for now.

Comment 3 Radar WebKit Bug Importer 2021-08-08 14:56:17 PDT

<rdar://problem/81675082>

Comment 4 Darin Adler 2021-08-22 21:20:51 PDT

Comment on attachment 434727 [details]
For EWS testing only

View in context: https://bugs.webkit.org/attachment.cgi?id=434727&action=review

> Source/WebCore/ChangeLog:10
> +        Ported from an abansoned Chromium change by Adithya Srinivasan.

Typo: abansoned