Bug 228691

Summary: Skip unnecessary invalidation of document level NodeList caches
Product: WebKit Reporter: Maciej Stachowiak <mjs>
Component: New BugsAssignee: Maciej Stachowiak <mjs>
Status: NEW    
Severity: Normal CC: cdumez, darin, esprehn+autocc, ews-watchlist, kangil.han, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
For EWS testing only mjs: commit-queue-

Maciej Stachowiak
Reported 2021-08-01 14:55:19 PDT
Skip unnecessary invalidation of document level NodeList caches
Attachments
For EWS testing only (2.44 KB, patch)
2021-08-01 14:56 PDT, Maciej Stachowiak 		mjs: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1 2021-08-01 14:56:46 PDT
Created attachment 434727 [details] For EWS testing only
Maciej Stachowiak
Comment 2 2021-08-01 14:58:53 PDT
Comment on attachment 434727 [details] For EWS testing only Not for landing. This version of the patch is like incorrect, as some NodeLists or Collections may need document-level invalidation even when the node isn't in the document. This is probably true for HTMLFormControlCollection, not clear what else may be affected. Testing if this builds and passes tests for now.
Radar WebKit Bug Importer
Comment 3 2021-08-08 14:56:17 PDT
<rdar://problem/81675082>
Darin Adler
Comment 4 2021-08-22 21:20:51 PDT
Comment on attachment 434727 [details] For EWS testing only View in context: https://bugs.webkit.org/attachment.cgi?id=434727&action=review > Source/WebCore/ChangeLog:10 > + Ported from an abansoned Chromium change by Adithya Srinivasan. Typo: abansoned
Note You need to log in before you can comment on or make changes to this bug.