Bug 22868

Summary:

xslt-enc16.xml and xslt-enc16to16.xml have wrong line endings on windows

Product:

WebKit

Reporter:

Tony Chang <tony>

Component:

WebCore Misc.

Assignee:

Tony Chang <tony>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Attachments:

Description	Flags
svn pd svn:eol-style	darin: review+

Tony Chang

Reported 2008-12-15 13:54:24 PST

The layout tests fast/xslt/xslt-enc16.xml and fast/xslt/xslt-enc16to16.xml have the wrong line endings when checked out on windows. It looks like there was an attempted fix in r32776: http://trac.webkit.org/changeset/32776 But this change didn't remove the svn:eol-style which is still set to native. I think if we just delete the svn:eol-style, the tests will be checked out properly. More information about the svn:mime-type here: http://svnbook.red-bean.com/en/1.1/apas08.html

Attachments
svn pd svn:eol-style (1.73 KB, patch) 2008-12-15 14:11 PST, Tony Chang	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Tony Chang

Comment 1 2008-12-15 14:11:23 PST

Created attachment 26032 [details] svn pd svn:eol-style

Darin Adler

Comment 2 2008-12-15 14:28:15 PST

Comment on attachment 26032 [details] svn pd svn:eol-style r=me

Alexey Proskuryakov

Comment 3 2009-01-11 01:51:59 PST

Committed revision 39790. This patch was made from non-root directory, so naively applying it modified WebKit/ChangeLog, not WebKit/LayoutTests/ChangeLog. To make landing easier, please make patches from root directory (you can pass a list of files/directories to scan to make the process faster, e.g. "svn-create-patch LayoutTests/ChangeLog LayoutTests/fast/xsl").

Note You need to log in before you can comment on or make changes to this bug.