Bug 228671

Summary:

REGRESSION (r271348): Web Inspector: Table headers have vertical scrollbar

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, hi, inspector-bugzilla-changes, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Image] Bug	none
Patch	none
[Image] With patch applied	none

Nikita Vasilyev

Reported 2021-07-30 16:54:29 PDT

Created attachment 434674 [details] [Image] Bug This is likely a recent regression.

Attachments
[Image] Bug (54.39 KB, image/png) 2021-07-30 16:54 PDT, Nikita Vasilyev	no flags	Details
Patch (1.28 KB, patch) 2021-08-12 01:24 PDT, Nikita Vasilyev	no flags	Details Formatted Diff Diff
[Image] With patch applied (95.80 KB, image/png) 2021-08-12 01:25 PDT, Nikita Vasilyev	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-08-06 16:55:16 PDT

<rdar://problem/81638278>

Nikita Vasilyev

Comment 2 2021-08-12 01:11:06 PDT

I bisected and it showed r271348. Which is interesting - it's a change in WebCore, not Web Inspector. > "The baseline of an 'inline-block' is the baseline of its last line box in the normal flow, unless it has either no in-flow line boxes > or if its 'overflow' property has a computed value other than 'visible', in which case the baseline is the bottom margin edge." > https://www.w3.org/TR/CSS22/visudet.html#leading

Nikita Vasilyev

Comment 3 2021-08-12 01:24:18 PDT

Created attachment 435400 [details] Patch Irregardless of the WebCore change that caused the regression, a less error-prone way to fix this is simply to set "overflow: hidden".

Nikita Vasilyev

Comment 4 2021-08-12 01:25:45 PDT

Created attachment 435401 [details] [Image] With patch applied No scrollbar with the patch applied.

Devin Rousso

Comment 5 2021-08-12 12:03:42 PDT

Comment on attachment 435400 [details] Patch rs=me

EWS

Comment 6 2021-08-12 12:07:33 PDT

Committed r280974 (240478@main): <https://commits.webkit.org/240478@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435400 [details].

Note You need to log in before you can comment on or make changes to this bug.