Bug 228629

Summary:

[WPE][GTK] build broken with python2 after r280382

Product:

WebKit

Reporter:

Carlos Alberto Lopez Perez <clopez>

Component:

CMake

Assignee:

Carlos Alberto Lopez Perez <clopez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, aperez, cgarcia, don.olmstead, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, mcatanzaro, msaboff, pnormand, ryuan.choi, saam, sergio, tzagallo

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=228290
https://bugs.webkit.org/show_bug.cgi?id=228628

Attachments:

Description	Flags
Patch	none

Description Carlos Alberto Lopez Perez 2021-07-29 18:13:43 PDT

Before r280382 it was possible to build webkit with python2

If we want to make python3 mandatory for building we should do that at the CMake level by raising the minimum version

But we should not call python3 directly, but ${PYTHON_EXECUTABLE} instead

Comment 1 Carlos Alberto Lopez Perez 2021-07-29 18:19:47 PDT

Created attachment 434597 [details]
Patch

Comment 2 Philippe Normand 2021-07-29 19:39:58 PDT

Comment on attachment 434597 [details]
Patch

Sorry about this, somehow I thought we were defaulting to Python3. Python2 has been EOL for a while now :)

Comment 3 EWS 2021-07-29 19:58:01 PDT

Committed r280466 (240101@main): <https://commits.webkit.org/240101@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434597 [details].