Bug 228629 - [WPE][GTK] build broken with python2 after r280382
Summary: [WPE][GTK] build broken with python2 after r280382
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-29 18:13 PDT by Carlos Alberto Lopez Perez
Modified: 2021-07-29 19:58 PDT (History)
15 users (show)

See Also:

Attachments
Patch (5.98 KB, patch)
2021-07-29 18:19 PDT, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2021-07-29 18:13:43 PDT 
Before r280382 it was possible to build webkit with python2

If we want to make python3 mandatory for building we should do that at the CMake level by raising the minimum version

But we should not call python3 directly, but ${PYTHON_EXECUTABLE} instead
Comment 1 Carlos Alberto Lopez Perez 2021-07-29 18:19:47 PDT 
Created attachment 434597 [details]
Patch
Comment 2 Philippe Normand 2021-07-29 19:39:58 PDT 
Comment on attachment 434597 [details]
Patch

Sorry about this, somehow I thought we were defaulting to Python3. Python2 has been EOL for a while now :)
Comment 3 EWS 2021-07-29 19:58:01 PDT 
Committed r280466 (240101@main): <https://commits.webkit.org/240101@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434597 [details].