Summary: | [WPE][GTK] Clean build broken with python3 after r280382 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||||
Component: | CMake | Assignee: | Philippe Normand <pnormand> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aakash_jain, aperez, bugs-noreply, commit-queue, jbedard, pnormand | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=228290 https://bugs.webkit.org/show_bug.cgi?id=228629 https://bugs.webkit.org/show_bug.cgi?id=229199 |
||||||||
Bug Depends on: | 229137 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Carlos Alberto Lopez Perez
2021-07-29 18:10:10 PDT
I attached a patch on bug 228629 to fix the build with python2, which should be enough for the moment to have the EWS working back As far as I can see, the issue (apparently) comes because the class AutoInstall in file Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py does not implement the method find_spec() which is new in python 3.4 See: https://docs.python.org/3/library/importlib.html#importlib.abc.MetaPathFinder.find_spec What puzzles me is that the script works if I call it directly with python3, it only fails if is called from the build :? The network issue happens because the build sandbox has no network access, unless either sccache or icecc is enabled. That would be easy to fix, but then... ... the webkitpy auto install black magic doesn't seem to work well in case it's triggered from concurrent processes. I tried to debug this for a few hours, gave up... ... I'll submit a patch getting rid of webkitpy in the glib/apply-build-revision-to-files.py. We don't need webkitpy for this, we can call svnversion, git svn info, or git log -1... depending on the kind of checkout... Created attachment 435583 [details]
Patch
Committed r281077 (240537@main): <https://commits.webkit.org/240537@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435583 [details]. Re-opened since this is blocked by bug 229137 Created attachment 435598 [details]
[fast-cq] Patch
Committed r281089 (240549@main): <https://commits.webkit.org/240549@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435598 [details]. |