Bug 228594

Summary: Move DeprecatedGlobalSettings into platform/
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED WONTFIX    
Severity: Normal CC: annulen, bfulgham, ews-watchlist, gyuyoung.kim, ryuan.choi, sam, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch jer.noble: review-

Description Jer Noble 2021-07-29 11:19:06 PDT
Move DeprecatedGlobalSettings into platform/
Comment 1 Jer Noble 2021-07-29 11:22:34 PDT
Created attachment 434541 [details]
Patch
Comment 2 Jer Noble 2021-07-29 11:25:09 PDT
Created attachment 434543 [details]
Patch
Comment 3 Jer Noble 2021-07-29 11:25:48 PDT
Created attachment 434544 [details]
Patch
Comment 4 Jer Noble 2021-07-29 11:51:50 PDT
Comment on attachment 434544 [details]
Patch

We'll need to replace the calls to HTMLMediaElement in here for this to work.
Comment 5 Sam Weinig 2021-07-29 13:53:56 PDT
Please consider not doing this. Platform code needs to avoid singletons just as much as WebCore, and propagating this pattern and establishing it as kosher rather than fixing the real issue doesn't seem like the right direction to me.

Rather, we should working to make more of platform self contained and not dependent on global state.
Comment 6 Radar WebKit Bug Importer 2021-08-05 11:20:16 PDT
<rdar://problem/81575750>
Comment 7 Brent Fulgham 2022-06-29 09:41:59 PDT
We decided to take a different route here.