Bug 228572

Summary:

REGRESSION(r279564): [GTK] Mouse wheel scrolling scrolls too little (take two)

Product:

WebKit

Reporter:

Michael Catanzaro <mcatanzaro>

Component:

WebKitGTK

Assignee:

Michael Catanzaro <mcatanzaro>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aperez, bugs-noreply, clord, mcatanzaro, mrobinson

Priority:

Version:

WebKit Nightly Build

Hardware:

OS:

Linux

See Also:

https://bugs.webkit.org/show_bug.cgi?id=224302
https://bugs.webkit.org/show_bug.cgi?id=227478

Attachments:

Description	Flags
Patch	none

Michael Catanzaro

Reported 2021-07-28 16:13:34 PDT

This is a repeat of bug #224686, we broke mouse wheel scroll speed again. I've started bisecting and am currently at r279963 as first known bad commit and r279541 as last known good. I see a few scrolling commits within this range, and will probably find the culprit when I continue bisecting tomorrow.

Attachments
Patch (10.13 KB, patch) 2021-07-30 06:28 PDT, Martin Robinson	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Michael Catanzaro

Comment 1 2021-07-29 10:50:03 PDT

I'm almost done bisecting and it looks like the bad commit is probably r279564 "[css-scroll-snap] Triggering a layout during scroll causes jittery scrolling on Mac when dragging the scrollbar." Hi Martin, do you have time to take a look?

Martin Robinson

Comment 2 2021-07-29 13:15:05 PDT

Yeah, I can take a look at this tomorrow or Monday. Thanks for the bisection.

Martin Robinson

Comment 3 2021-07-30 05:32:30 PDT

This problem shows up when you scroll rapidly with scroll wheel and with smooth scrolling turned on. The issue here seems to be that when ScrollAnimator handles a wheel event, it calculates the destination based on the current position, rather than the current target position for the running animation. r279564 uncovered this issue by fixing a bug in ScrollAnimationSmooth that disregarded the requested position in favor of a bogus one, but also making the scrolling by delta relative to the current position (rather than the desired one). This effectively means that the faster you scroll, the slower WebKit scrolls. This is, to say the least, wrong.

Martin Robinson

Comment 4 2021-07-30 06:28:27 PDT

Created attachment 434617 [details] Patch

Michael Catanzaro

Comment 5 2021-07-30 06:32:31 PDT

Comment on attachment 434617 [details] Patch Nice test!

EWS

Comment 6 2021-07-31 08:43:45 PDT

Committed r280515 (240147@main): <https://commits.webkit.org/240147@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434617 [details].

Note You need to log in before you can comment on or make changes to this bug.