Bug 228549

Summary: RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer should update m_currentRotationSessionAngle
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description youenn fablet 2021-07-28 05:31:33 PDT
RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer should update m_currentRotationSessionAngle
Comment 1 youenn fablet 2021-07-28 05:31:42 PDT
<rdar://80608977>
Comment 2 Radar WebKit Bug Importer 2021-07-28 05:31:59 PDT
<rdar://problem/81212597>
Comment 3 youenn fablet 2021-07-28 05:42:47 PDT
Created attachment 434420 [details]
Patch
Comment 4 Eric Carlson 2021-07-28 07:01:39 PDT
Comment on attachment 434420 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434420&action=review

> Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm:78
> +        IntSize size = { (int)pixelWidth , (int)pixelHeight };

Nit: the local isn't strictly necessary.
Comment 5 youenn fablet 2021-07-28 23:52:14 PDT
Created attachment 434503 [details]
Patch for landing
Comment 6 EWS 2021-07-29 04:22:06 PDT
Committed r280421 (240061@main): <https://commits.webkit.org/240061@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434503 [details].