Bug 228325

Summary: REGRESSION(r280078): broke fast/images/exif-orientation-composited.html on windows
Product: WebKit Reporter: zsun
Component: CSSAssignee: zsun
Status: RESOLVED DUPLICATE    
Severity: Normal CC: ayumi_kojima, changseok, commit-queue, darin, esprehn+autocc, ews-watchlist, glenn, jfernandez, kondapallykalyan, pdr, rego, svillar, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 233184    
Bug Blocks: 228022    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

zsun
Reported 2021-07-27 08:13:28 PDT
REGRESSION(r280078): broke fast/images/exif-orientation-composited.html on windows
Attachments
Patch (1.87 KB, patch)
2021-07-27 08:23 PDT, zsun 		no flags
DetailsFormatted DiffDiff
Patch (2.00 KB, patch)
2021-07-27 08:36 PDT, zsun 		no flags
DetailsFormatted DiffDiff
Patch (2.00 KB, patch)
2021-07-27 08:41 PDT, zsun 		no flags
DetailsFormatted DiffDiff
Patch (1.99 KB, patch)
2021-07-28 01:53 PDT, zsun 		no flags
DetailsFormatted DiffDiff
Patch (3.31 KB, patch)
2021-08-16 01:40 PDT, zsun 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
zsun
Comment 1 2021-07-27 08:23:23 PDT
Created attachment 434286 [details] Patch
zsun
Comment 2 2021-07-27 08:36:40 PDT
Created attachment 434289 [details] Patch
zsun
Comment 3 2021-07-27 08:41:32 PDT
Created attachment 434290 [details] Patch
Darin Adler
Comment 4 2021-07-27 08:54:18 PDT
Comment on attachment 434290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434290&action=review > Source/WebCore/ChangeLog:12 > + No test needed. Test fast/images/exif-orientation-composited.html on windows is > + enough to cover the affected code. Why only on Windows? Does not make logical sense that this is untestable on platforms other than Windows.
zsun
Comment 5 2021-07-28 01:01:53 PDT
(In reply to Darin Adler from comment #4) > Comment on attachment 434290 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=434290&action=review > > > Source/WebCore/ChangeLog:12 > > + No test needed. Test fast/images/exif-orientation-composited.html on windows is > > + enough to cover the affected code. > > Why only on Windows? Does not make logical sense that this is untestable on > platforms other than Windows. The regression seems happening only on windows for this test. However, this test runs on all other platforms as well.
zsun
Comment 6 2021-07-28 01:53:04 PDT
Created attachment 434412 [details] Patch
zsun
Comment 7 2021-07-29 04:37:13 PDT
Darin, Is it Okay to land this patch? Thanks!
Radar WebKit Bug Importer
Comment 8 2021-08-03 08:14:16 PDT
<rdar://problem/81462538>
Truitt Savell
Comment 9 2021-08-12 09:52:49 PDT
Is this patch ready to land? It would help clean up Windows EWS
Darin Adler
Comment 10 2021-08-12 09:54:43 PDT
I asked a question and didn’t review the patch yet. That one question wasn’t my review. This patch needs review? set on it so someone reviews it!
Darin Adler
Comment 11 2021-08-12 09:55:02 PDT
We need a grid or layout expert to review.
Darin Adler
Comment 12 2021-08-12 10:31:15 PDT
(In reply to Truitt Savell from comment #9) > Is this patch ready to land? It would help clean up Windows EWS We should skip or expect failure on the test on Windows to clean up Windows EWS and then re-enable it as part of this patch
Sergio Villar Senin
Comment 13 2021-08-13 00:29:22 PDT
Actually that test does not have any grid. Are we sure the grid patch caused the regression?
ayumi_kojima
Comment 14 2021-08-13 08:59:13 PDT
(In reply to Darin Adler from comment #12) > (In reply to Truitt Savell from comment #9) > > Is this patch ready to land? It would help clean up Windows EWS > > We should skip or expect failure on the test on Windows to clean up Windows > EWS and then re-enable it as part of this patch Updated test expectations for Windows-EWS so that it won't show up on EWS. https://trac.webkit.org/changeset/281020/webkit
zsun
Comment 15 2021-08-16 01:40:24 PDT
Created attachment 435579 [details] Patch
Javier Fernandez
Comment 16 2021-09-03 10:09:49 PDT
Comment on attachment 435579 [details] Patch r=me
EWS
Comment 17 2021-09-03 10:30:47 PDT
Committed r282008 (241315@main): <https://commits.webkit.org/241315@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435579 [details].
WebKit Commit Bot
Comment 18 2021-11-16 03:38:03 PST
Re-opened since this is blocked by bug 233184
zsun
Comment 19 2021-11-18 05:25:10 PST
This issue has been addressed in bug 228022 *** This bug has been marked as a duplicate of bug 228022 ***
Note You need to log in before you can comment on or make changes to this bug.