| Summary: | REGRESSION(r280078): broke fast/images/exif-orientation-composited.html on windows | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zsun | ||||||||||||
| Component: | CSS | Assignee: | zsun | ||||||||||||
| Status: | RESOLVED DUPLICATE | ||||||||||||||
| Severity: | Normal | CC: | ayumi_kojima, changseok, commit-queue, darin, esprehn+autocc, ews-watchlist, glenn, jfernandez, kondapallykalyan, pdr, rego, svillar, tsavell, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | 233184 | ||||||||||||||
| Bug Blocks: | 228022 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
zsun
2021-07-27 08:13:28 PDT
Created attachment 434286 [details]
Patch
Created attachment 434289 [details]
Patch
Created attachment 434290 [details]
Patch
Comment on attachment 434290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434290&action=review > Source/WebCore/ChangeLog:12 > + No test needed. Test fast/images/exif-orientation-composited.html on windows is > + enough to cover the affected code. Why only on Windows? Does not make logical sense that this is untestable on platforms other than Windows. (In reply to Darin Adler from comment #4) > Comment on attachment 434290 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=434290&action=review > > > Source/WebCore/ChangeLog:12 > > + No test needed. Test fast/images/exif-orientation-composited.html on windows is > > + enough to cover the affected code. > > Why only on Windows? Does not make logical sense that this is untestable on > platforms other than Windows. The regression seems happening only on windows for this test. However, this test runs on all other platforms as well. Created attachment 434412 [details]
Patch
Darin, Is it Okay to land this patch? Thanks! Is this patch ready to land? It would help clean up Windows EWS I asked a question and didn’t review the patch yet. That one question wasn’t my review. This patch needs review? set on it so someone reviews it! We need a grid or layout expert to review. (In reply to Truitt Savell from comment #9) > Is this patch ready to land? It would help clean up Windows EWS We should skip or expect failure on the test on Windows to clean up Windows EWS and then re-enable it as part of this patch Actually that test does not have any grid. Are we sure the grid patch caused the regression? (In reply to Darin Adler from comment #12) > (In reply to Truitt Savell from comment #9) > > Is this patch ready to land? It would help clean up Windows EWS > > We should skip or expect failure on the test on Windows to clean up Windows > EWS and then re-enable it as part of this patch Updated test expectations for Windows-EWS so that it won't show up on EWS. https://trac.webkit.org/changeset/281020/webkit Created attachment 435579 [details]
Patch
Comment on attachment 435579 [details]
Patch
r=me
Committed r282008 (241315@main): <https://commits.webkit.org/241315@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435579 [details]. Re-opened since this is blocked by bug 233184 This issue has been addressed in bug 228022 *** This bug has been marked as a duplicate of bug 228022 *** |