Summary: | [Modern Media Controls] [macOS] Overflow button still shows as `on` even after contextmenu is dismissed | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||||
Component: | Media | Assignee: | Devin Rousso <hi> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | calvaris, eric.carlson, ews-watchlist, glenn, hi, jer.noble, peng.liu6, philipj, sergio, webkit-bug-importer, wenson_hsieh | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=228725 | ||||||||||||
Attachments: |
|
Description
Devin Rousso
2021-07-26 17:14:19 PDT
Created attachment 434260 [details]
Patch
Comment on attachment 434260 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434260&action=review > Source/WebKit/WebProcess/WebPage/WebContextMenu.cpp:71 > + m_page->shouldWaitForContextMenuToShow(); Nit - `shouldWaitForContextMenuToShow()` sounds a bit like the name of a const getter. Perhaps something along the lines of `startWaitingForContextMenuToShow()`? Comment on attachment 434260 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434260&action=review > Source/WebCore/ChangeLog:21 > + as that's the signal to the `MediaController` that the contextmenu interaction is ove, which s/ove/over/ Created attachment 434303 [details]
Patch
Created attachment 434305 [details]
Patch
oops forgot new test files
Created attachment 434315 [details]
Patch
fix test expectations
Committed r280374 (240018@main): <https://commits.webkit.org/240018@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434315 [details]. |