Bug 228310

Summary: [Modern Media Controls] [macOS] Overflow button still shows as `on` even after contextmenu is dismissed
Product: WebKit Reporter: Devin Rousso <hi>
Component: MediaAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, eric.carlson, ews-watchlist, glenn, hi, jer.noble, peng.liu6, philipj, sergio, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=228725
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Devin Rousso 2021-07-26 17:14:19 PDT
# STEPS TO REPRODUCE
1. go to any page with a `<video>`
2. click the >> overflow button
3. dismiss the contextmenu (e.g. click outside, escape, etc.)

# EXPECTED
the >> overflow button would no longer be white

# ACTUAL
the >> overflow button is still white
Comment 1 Devin Rousso 2021-07-26 17:16:28 PDT
<rdar://problem/81124786>
Comment 2 Devin Rousso 2021-07-26 17:24:31 PDT
Created attachment 434260 [details]
Patch
Comment 3 Wenson Hsieh 2021-07-26 17:37:54 PDT
Comment on attachment 434260 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434260&action=review

> Source/WebKit/WebProcess/WebPage/WebContextMenu.cpp:71
> +    m_page->shouldWaitForContextMenuToShow();

Nit - `shouldWaitForContextMenuToShow()` sounds a bit like the name of a const getter. Perhaps something along the lines of `startWaitingForContextMenuToShow()`?
Comment 4 Eric Carlson 2021-07-27 11:21:58 PDT
Comment on attachment 434260 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434260&action=review

> Source/WebCore/ChangeLog:21
> +        as that's the signal to the `MediaController` that the contextmenu interaction is ove, which

s/ove/over/
Comment 5 Devin Rousso 2021-07-27 11:49:46 PDT
Created attachment 434303 [details]
Patch
Comment 6 Devin Rousso 2021-07-27 11:54:07 PDT
Created attachment 434305 [details]
Patch

oops forgot new test files
Comment 7 Devin Rousso 2021-07-27 14:24:31 PDT
Created attachment 434315 [details]
Patch

fix test expectations
Comment 8 EWS 2021-07-27 20:56:52 PDT
Committed r280374 (240018@main): <https://commits.webkit.org/240018@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434315 [details].