Bug 228295

Summary: Rename activeWindow to incumbentWindow in the Location class
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ggaren, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=228287
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2021-07-26 13:10:33 PDT 
Rename activeWindow to incumbentWindow in the Location class, since this is the naming used both in the HTML specification and Location.idl.
Comment 1 Chris Dumez 2021-07-26 13:11:40 PDT 
Created attachment 434229 [details]
Patch
Comment 2 Darin Adler 2021-07-26 13:14:26 PDT 
Comment on attachment 434229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434229&action=review

> Source/WebCore/page/Location.cpp:284
>      URL completedURL = firstFrame->document()->completeURL(urlString);
> +
> +
>      // FIXME: The specification says to throw a SyntaxError if the URL is not valid.

Not sure why there are two blank lines here.
Comment 3 Chris Dumez 2021-07-26 13:15:26 PDT 
Created attachment 434230 [details]
Patch
Comment 4 EWS 2021-07-26 14:19:26 PDT 
Committed r280313 (239963@main): <https://commits.webkit.org/239963@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434230 [details].
Comment 5 Radar WebKit Bug Importer 2021-07-26 14:20:17 PDT 
<rdar://problem/81129964>