| Summary: | RenderThemeWin buttons have weird heavy text | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adele Peterson <adele> | ||||||
| Component: | Forms | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | hyatt, ojan | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Adele Peterson
2008-12-12 13:56:30 PST
Created attachment 25986 [details]
patch
Potential fix. Not sure if the default GUI font is right here. But it matches Firefox.
This is wrong IMO. - fontDescription.setSpecifiedSize(abs(logFont.lfHeight)); + fontDescription.setSpecifiedSize(fontSize); Just pass in the size you want instead. It's an argument to fillFontDescription, so i don't see why you'd ignore the argument. The rest of it looks good. Eyeballing Mozilla's code they do indeed use the stock DEFAULT_GUI_FONT for buttons. Created attachment 26079 [details]
now with changelog
The patch does explicitly set the font size for the controls, and after Hyatt and I talked more about the patch, I think this is right.
Chromium has a slightly different strategy that we may want to merge with in the future. But for now, this will get us closer to a reasonable control look w/ RenderThemeWin.
Comment on attachment 26079 [details]
now with changelog
r=me
|