Bug 22827

Summary: RenderThemeWin buttons have weird heavy text
Product: WebKit Reporter: Adele Peterson <adele>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch
none
now with changelog darin: review+

Adele Peterson
Reported 2008-12-12 13:56:30 PST
RenderThemeWin buttons have weird heavy text
Attachments
patch (3.13 KB, patch)
2008-12-12 13:59 PST, Adele Peterson 		no flags
DetailsFormatted DiffDiff
now with changelog (3.86 KB, patch)
2008-12-16 17:05 PST, Adele Peterson 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adele Peterson
Comment 1 2008-12-12 13:59:29 PST
Created attachment 25986 [details] patch Potential fix. Not sure if the default GUI font is right here. But it matches Firefox.
Dave Hyatt
Comment 2 2008-12-12 14:15:02 PST
This is wrong IMO. - fontDescription.setSpecifiedSize(abs(logFont.lfHeight)); + fontDescription.setSpecifiedSize(fontSize); Just pass in the size you want instead. It's an argument to fillFontDescription, so i don't see why you'd ignore the argument. The rest of it looks good. Eyeballing Mozilla's code they do indeed use the stock DEFAULT_GUI_FONT for buttons.
Adele Peterson
Comment 3 2008-12-16 17:05:20 PST
Created attachment 26079 [details] now with changelog The patch does explicitly set the font size for the controls, and after Hyatt and I talked more about the patch, I think this is right. Chromium has a slightly different strategy that we may want to merge with in the future. But for now, this will get us closer to a reasonable control look w/ RenderThemeWin.
Darin Adler
Comment 4 2008-12-16 17:41:14 PST
Comment on attachment 26079 [details] now with changelog r=me
Adele Peterson
Comment 5 2008-12-16 17:55:43 PST
Committed r39349
Note You need to log in before you can comment on or make changes to this bug.