|Summary:||RenderThemeWin buttons have weird heavy text|
|Product:||WebKit||Reporter:||Adele Peterson <adele>|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Adele Peterson 2008-12-12 13:56:30 PST
RenderThemeWin buttons have weird heavy text
Comment 1 Adele Peterson 2008-12-12 13:59:29 PST
Created attachment 25986 [details] patch Potential fix. Not sure if the default GUI font is right here. But it matches Firefox.
Comment 2 Dave Hyatt 2008-12-12 14:15:02 PST
This is wrong IMO. - fontDescription.setSpecifiedSize(abs(logFont.lfHeight)); + fontDescription.setSpecifiedSize(fontSize); Just pass in the size you want instead. It's an argument to fillFontDescription, so i don't see why you'd ignore the argument. The rest of it looks good. Eyeballing Mozilla's code they do indeed use the stock DEFAULT_GUI_FONT for buttons.
Comment 3 Adele Peterson 2008-12-16 17:05:20 PST
Created attachment 26079 [details] now with changelog The patch does explicitly set the font size for the controls, and after Hyatt and I talked more about the patch, I think this is right. Chromium has a slightly different strategy that we may want to merge with in the future. But for now, this will get us closer to a reasonable control look w/ RenderThemeWin.
Comment 4 Darin Adler 2008-12-16 17:41:14 PST
Comment on attachment 26079 [details] now with changelog r=me