Bug 228193

Summary: AirStackSlot's uint16_t byte size is too small
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Saam Barati
Reported 2021-07-22 13:20:25 PDT
...
Attachments
patch (8.54 KB, patch)
2021-07-22 13:25 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2021-07-22 13:21:07 PDT
<rdar://80888059>
Saam Barati
Comment 2 2021-07-22 13:25:23 PDT
Created attachment 434030 [details] patch
Mark Lam
Comment 3 2021-07-22 13:30:55 PDT
Comment on attachment 434030 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=434030&action=review r=me > Source/JavaScriptCore/b3/B3Procedure.cpp:76 > +Air::StackSlot* Procedure::addStackSlot(uint64_t byteSize) Let's use size_t instead of uint64_t in all these size values.
Saam Barati
Comment 4 2021-07-22 14:31:57 PDT
Comment on attachment 434030 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=434030&action=review >> Source/JavaScriptCore/b3/B3Procedure.cpp:76 >> +Air::StackSlot* Procedure::addStackSlot(uint64_t byteSize) > > Let's use size_t instead of uint64_t in all these size values. I picked uint64_t explicitly just so this code would work if we ever ported to 32-bit.
EWS
Comment 5 2021-07-22 14:37:08 PDT
Committed r280198 (239886@main): <https://commits.webkit.org/239886@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434030 [details].
Note You need to log in before you can comment on or make changes to this bug.