| Summary: | AirStackSlot's uint16_t byte size is too small | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, tzagallo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Saam Barati
2021-07-22 13:20:25 PDT
Created attachment 434030 [details]
patch
Comment on attachment 434030 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=434030&action=review r=me > Source/JavaScriptCore/b3/B3Procedure.cpp:76 > +Air::StackSlot* Procedure::addStackSlot(uint64_t byteSize) Let's use size_t instead of uint64_t in all these size values. Comment on attachment 434030 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=434030&action=review >> Source/JavaScriptCore/b3/B3Procedure.cpp:76 >> +Air::StackSlot* Procedure::addStackSlot(uint64_t byteSize) > > Let's use size_t instead of uint64_t in all these size values. I picked uint64_t explicitly just so this code would work if we ever ported to 32-bit. Committed r280198 (239886@main): <https://commits.webkit.org/239886@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434030 [details]. |