Bug 228181

Summary: REGRESSION (r279992): Crashes under RemoteLayerBackingStore::applyBackingStoreToLayer() in macCatalyst
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, dino, sam, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Tim Horton 2021-07-22 02:57:34 PDT 
REGRESSION (r279992): Crashes under RemoteLayerBackingStore::applyBackingStoreToLayer() in macCatalyst
Comment 1 Tim Horton 2021-07-22 02:58:11 PDT 
Created attachment 434002 [details]
Patch
Comment 2 Tim Horton 2021-07-22 02:58:15 PDT 
<rdar://problem/80923581>
Comment 3 Daniel Bates 2021-07-22 10:09:49 PDT 
Comment on attachment 434002 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434002&action=review

Patch looks good.

> Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:429
> +    RetainPtr<id> contents = nil;

OK as-is. No change needed. Thoughts about removing the = nil and letting the default constructor initialize this?
Comment 4 Tim Horton 2021-07-22 10:24:28 PDT 
(In reply to Daniel Bates from comment #3)
> Comment on attachment 434002 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434002&action=review
> 
> Patch looks good.
> 
> > Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:429
> > +    RetainPtr<id> contents = nil;
> 
> OK as-is. No change needed. Thoughts about removing the = nil and letting
> the default constructor initialize this?

Heh, sure, certainly.
Comment 5 Tim Horton 2021-07-22 10:34:42 PDT 
Created attachment 434018 [details]
Patch
Comment 6 EWS 2021-07-22 11:04:10 PDT 
Committed r280183 (239876@main): <https://commits.webkit.org/239876@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434018 [details].