Bug 228175

Summary:	Expose document ordering in WebKit internals object
Product:	WebKit	Reporter:	Frédéric Wang (:fredw) <fred.wang>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	NEW
Severity:	Normal	CC:	darin, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Frédéric Wang (:fredw)

Reported 2021-07-21 23:27:35 PDT

Currently tree ordering is tested by Tools/TestWebKitAPI/Tests/WebCore/DocumentOrder.cpp For this purpose, documentOrder() is WEBKIT_EXPORTed. Instead, we should expose these in WebKit internals object, then replace DocumentOrder.cpp with tests written in JavaScript.

Attachments
Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2021-07-23 12:30:28 PDT

Alternatively, we may be able to export template implementations by using WEBCORE_EXPORT on the explicit template instantiations as we do in JSDOMConvertNumbers.h.

Frédéric Wang (:fredw)

Comment 2 2021-07-23 12:44:22 PDT

(In reply to Darin Adler from comment #1) > Alternatively, we may be able to export template implementations by using > WEBCORE_EXPORT on the explicit template instantiations as we do in > JSDOMConvertNumbers.h. mmh, I had tried something like that but obtained build failures. It's worth trying again though.

Radar WebKit Bug Importer

Comment 3 2021-07-28 23:28:16 PDT

<rdar://problem/81255637>

Note You need to log in before you can comment on or make changes to this bug.