Bug 228063

Summary: Ignore weak external symbols in clang coverage builds using check-for-weak-vtables-and-externals
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, jbedard, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 226562, 226684    
Bug Blocks:    
Attachments:
Description Flags
Patch v1 ews-feeder: commit-queue-

David Kilzer (:ddkilzer)
Reported 2021-07-18 13:04:53 PDT
Ignore weak external symbols in clang coverage builds using check-for-weak-vtables-and-externals. It turns out that -exported_symbol and -unexported_symbol can't be used together when linking: ld: can't use -unexported_symbol and -exported_symbol clang: error: linker command failed with exit code 1 (use -v to see invocation) So go back to the solution from Bug 226562 (effectively reverting the change for Bug 226684). <rdar://problem/80477138>
Attachments
Patch v1 (2.56 KB, patch)
2021-07-18 13:13 PDT, David Kilzer (:ddkilzer) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2021-07-18 13:13:59 PDT
Created attachment 433757 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 2 2021-07-18 13:15:10 PDT
Note that the libwebrtc project was the first project failing with a coverage build before this change.
EWS
Comment 3 2021-07-18 15:59:35 PDT
Committed r280021 (239763@main): <https://commits.webkit.org/239763@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433757 [details].
Note You need to log in before you can comment on or make changes to this bug.