| Summary: | [JSC] Simplify sampling-profiler-regexp.js test | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | saam, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Yusuke Suzuki
2021-07-16 15:59:39 PDT
Created attachment 433712 [details]
Patch
Comment on attachment 433712 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433712&action=review > JSTests/stress/sampling-profiler/samplingProfiler.js:37 > +const VERBOSE = true; id you want to check this part in? > JSTests/stress/sampling-profiler/samplingProfiler.js:69 > if (isRunFromRunTest) > - stackTrace = [...stackTrace, "runTest", "(program)"]; > + stackTrace = [...stackTraceOrString, "runTest", "(program)"]; > else > - stackTrace = [...stackTrace]; > + stackTrace = [...stackTraceOrString]; does this make sense if the stack trace is a string? Comment on attachment 433712 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433712&action=review >> JSTests/stress/sampling-profiler/samplingProfiler.js:37 >> +const VERBOSE = true; > > id you want to check this part in? Oops! Nice catch. We should make it false. >> JSTests/stress/sampling-profiler/samplingProfiler.js:69 >> + stackTrace = [...stackTraceOrString]; > > does this make sense if the stack trace is a string? We have `if (typeof stackTraceOrString === 'string') {` branch before this :) Created attachment 433713 [details]
Patch
Comment on attachment 433712 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433712&action=review >>> JSTests/stress/sampling-profiler/samplingProfiler.js:37 >>> +const VERBOSE = true; >> >> id you want to check this part in? > > Oops! Nice catch. We should make it false. 👍 (I meant to write "did" for the first word here) >>> JSTests/stress/sampling-profiler/samplingProfiler.js:69 >>> + stackTrace = [...stackTraceOrString]; >> >> does this make sense if the stack trace is a string? > > We have `if (typeof stackTraceOrString === 'string') {` branch before this :) 👍 I missed that the above branch always returns. Committed r280011 (239753@main): <https://commits.webkit.org/239753@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433713 [details]. |