Bug 228026

Summary: Web Inspector: propagate changes from `Page.overrideSetting` to the UIProcess
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: NEW    
Severity: Normal CC: bdakin, cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, hi, inspector-bugzilla-changes, jer.noble, joepeck, kondapallykalyan, pangle, philipj, sergio, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch hi: review?

Devin Rousso
Reported 2021-07-16 10:07:30 PDT
this would allow `WKWebView` clients to see whether Web Inspector has disabled various settings/preferences
Attachments
Patch (56.24 KB, patch)
2021-07-16 10:38 PDT, Devin Rousso 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (55.34 KB, patch)
2021-07-16 10:55 PDT, Devin Rousso 		hi: review?
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2021-07-16 10:38:33 PDT
Created attachment 433683 [details] Patch
Wenson Hsieh
Comment 2 2021-07-16 10:46:54 PDT
Comment on attachment 433683 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433683&action=review > Source/WebKit/UIProcess/WebPageProxy.h:794 > + bool shouldAlwaysUseMaximumObscuredInsets() const { return m_shouldAlwaysUseMaximumObscuredInsets; } > + void setShouldAlwaysUseMaximumObscuredInsets(bool); This looks unused.
Devin Rousso
Comment 3 2021-07-16 10:50:18 PDT
Comment on attachment 433683 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433683&action=review >> Source/WebKit/UIProcess/WebPageProxy.h:794 >> + void setShouldAlwaysUseMaximumObscuredInsets(bool); > > This looks unused. oops! forgot to remove old code 😅
Devin Rousso
Comment 4 2021-07-16 10:55:34 PDT
Created attachment 433686 [details] Patch
Radar WebKit Bug Importer
Comment 5 2021-07-23 10:08:14 PDT
<rdar://problem/81023726>
Note You need to log in before you can comment on or make changes to this bug.