Bug 227965

Summary: Link against Catalyst ANGLE-shared.dylib when linking Catalyst WebCore.framework
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Alex Christensen 2021-07-14 12:54:34 PDT
Link against Catalyst ANGLE-shared.dylib when linking Catalyst WebCore.framework
Comment 1 Alex Christensen 2021-07-14 12:57:43 PDT
Created attachment 433519 [details]
Patch
Comment 2 Alex Christensen 2021-07-14 12:57:46 PDT
<rdar://problem/76284889>
Comment 3 Tim Horton 2021-07-14 13:03:08 PDT
Comment on attachment 433519 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433519&action=review

> Source/WebCore/ChangeLog:11
> +        At runtime, though, we realize we are opening the wrong dylib and bad things happen.

I don't think we do notice, actually, it just has a few critical #ifdeffed behavioral differences that break things :)

> Source/WebCore/ChangeLog:13
> +        The solution is to look in the Catalyst WebCore framework directory when WK_USE_ALTERNATE_FRAMEWORKS_DIR is YES,

No idea how I missed this one years ago, I'm surprised it hadn't come up before! Thank you.
Comment 4 Alex Christensen 2021-07-14 15:12:17 PDT
http://trac.webkit.org/r279925