Bug 227965 - Link against Catalyst ANGLE-shared.dylib when linking Catalyst WebCore.framework
Summary: Link against Catalyst ANGLE-shared.dylib when linking Catalyst WebCore.framework
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-14 12:54 PDT by Alex Christensen
Modified: 2021-07-14 15:12 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.66 KB, patch)
2021-07-14 12:57 PDT, Alex Christensen 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-07-14 12:54:34 PDT 
Link against Catalyst ANGLE-shared.dylib when linking Catalyst WebCore.framework
Comment 1 Alex Christensen 2021-07-14 12:57:43 PDT 
Created attachment 433519 [details]
Patch
Comment 2 Alex Christensen 2021-07-14 12:57:46 PDT 
<rdar://problem/76284889>
Comment 3 Tim Horton 2021-07-14 13:03:08 PDT 
Comment on attachment 433519 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433519&action=review

> Source/WebCore/ChangeLog:11
> +        At runtime, though, we realize we are opening the wrong dylib and bad things happen.

I don't think we do notice, actually, it just has a few critical #ifdeffed behavioral differences that break things :)

> Source/WebCore/ChangeLog:13
> +        The solution is to look in the Catalyst WebCore framework directory when WK_USE_ALTERNATE_FRAMEWORKS_DIR is YES,

No idea how I missed this one years ago, I'm surprised it hadn't come up before! Thank you.
Comment 4 Alex Christensen 2021-07-14 15:12:17 PDT 
http://trac.webkit.org/r279925