Bug 227959

Summary:

Fix type of exceptions thrown in the WebAudio API

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Web Audio

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, clopez, darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sam, sergio, webkit-bug-importer, youennf, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2021-07-14 10:39:41 PDT

AudioNode constructors should throw a NotSupportedError when the requested number of channels is too large. Currently, WebKit throws an IndexSizeError but this doesn't match Blink / Gecko and causes some WPT tests to fail.

Comment 1 Chris Dumez 2021-07-14 11:37:45 PDT

Created attachment 433513 [details]
Patch

Comment 2 Yusuke Suzuki 2021-07-14 13:12:59 PDT

Comment on attachment 433513 [details]
Patch

r=me

Comment 3 EWS 2021-07-14 13:39:50 PDT

Committed r279917 (239666@main): <https://commits.webkit.org/239666@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433513 [details].

Comment 4 Radar WebKit Bug Importer 2021-07-14 13:40:18 PDT

<rdar://problem/80594511>